Config fixes v1.14 #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the 'focused' element was stale, i.e. still pointing to the button that took you into the config page. - when pressed (via enter key) it tried to load config with duplicated key, e.g. config path was ["rendersettings", "rendersettings"] which led to an exception being thrown in ConfigOptionList::setPath - now we unfocus when reloading a ConfigOptionList
Going "back" from config screen is expected to take you to the mod list screen you started at.
- Don't re-init the ConfigOptionList - Add method to re-size the (existing) ConfigOptionList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've been using your mod config UIs for my own mods, and fixed a few issues while I was at it.
Thanks for sharing, it's been really helpful for reintroducing a config UI within 1.14.