Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.14.4] Config UI values reset when resizing the window #70

Open
feldim2425 opened this issue Nov 18, 2019 · 0 comments
Open

[1.14.4] Config UI values reset when resizing the window #70

feldim2425 opened this issue Nov 18, 2019 · 0 comments
Labels
Bug Something that shouldn't be that way minor The bug is not game breaking and doen't have to be fixed immediately

Comments

@feldim2425
Copy link
Owner

feldim2425 commented Nov 18, 2019 •
edited
Loading

Edited values in the config gui (without saving) get reset when resizing the window.

Reproduce:

  1. Open config ui (Mods -> MoreOverlay -> Config)
  2. Edit any value
  3. Resize the minecraft window

Developer Note:
Config list gets reinitialized every time the window size changes (due to the internal handling by minecraft) but configs don't get copied. Potential fix rewriting the config list to handle the init itself and not generating a new one every time, probably required rewriting the AbstractList class.
@feldim2425 feldim2425 added Bug Something that shouldn't be that way minor The bug is not game breaking and doen't have to be fixed immediately labels Nov 18, 2019
kmcnaught added a commit to kmcnaught/MoreOverlays that referenced this issue Mar 2, 2020
@kmcnaught
Fix issue feldim2425#70: resetting values when resizing
b4e3c25 
- Don't re-init the ConfigOptionList
- Add method to re-size the (existing) ConfigOptionList
@kmcnaught kmcnaught mentioned this issue Mar 2, 2020
Open
kmcnaught added a commit to kmcnaught/MoreOverlays that referenced this issue Mar 2, 2020
@kmcnaught
Fix issue feldim2425#70: resetting values when resizing
79953c1 
- Don't re-init the ConfigOptionList
- Add method to re-size the (existing) ConfigOptionList
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something that shouldn't be that way minor The bug is not game breaking and doen't have to be fixed immediately
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@feldim2425