Deprecate PrinterColumn annotation to move it to the crd-generator module #5342
Conversation
andreaTP
requested review from
manusa,
oscerd,
rohanKanojia,
shawkins and
sunix
as code owners
|
FYI @bachmanity1 |
andreaTP
force-pushed
the
deprecate-printer-col
branch
from
352e0f5 to
8efaf0a
Compare
fixed and squashed. |
| @@ -42,7 +42,7 @@ public enum ExcludedTopic { | |||
| @PrinterColumn(name = "jokeCategory", priority = 1) | |||
| @JsonPropertyDescription("category-description") | |||
| private Category category = Category.Any; | |||
| @PrinterColumn(name = "excludedTopics") | |||
| @io.fabric8.kubernetes.model.annotation.PrinterColumn(name = "excludedTopics") | |||
There was a problem hiding this comment.
I think you're still using deprecated PrinterColumn here.
There was a problem hiding this comment.
+1. I think imports in the io.fabric8.crd.generator.zookeeper.v1.ZookeeperStatus also must be updated because it still uses deprecated version of PrinterColumn.
There was a problem hiding this comment.
Yes, that's intentional, we want to test that both annotations will work.
There was a problem hiding this comment.
then when do you plan to replace old annotations?
There was a problem hiding this comment.
With the release of the next Minor, theoretically 6.9 at this point.
andreaTP
force-pushed
the
deprecate-printer-col
branch
from
8efaf0a to
fd12d6f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Description
Follow up from #5339
Type of change
test, version modification, documentation, etc.)
Checklist