Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include priority field in the PrinterColumn annotation #5339

Closed
bachmanity1 opened this issue Jul 19, 2023 · 1 comment · Fixed by #5340
Closed

Include priority field in the PrinterColumn annotation #5339

bachmanity1 opened this issue Jul 19, 2023 · 1 comment · Fixed by #5340
Assignees
Labels
component/crd-generator Related to the CRD generator enhancement
Milestone

Comments

@bachmanity1
Copy link
Contributor

Is your enhancement related to a problem? Please describe

It looks like that currently it's not possible to define a priority of a printer column during CRD generation, i.e. all the generated additionalPrinterColumns have a default priority of 0. I would like some printer columns to have a non-zero priority so that they'll appear only in the wide view (using the -o wide flag).
Reference https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#priority

Describe the solution you'd like

I want to include a priority field in the PrinterColumn annotation. If possible I would like to work on this, I think this is not a very difficult task and also a good exercise to start contributing.

Describe alternatives you've considered

No response

Additional context

No response

@andreaTP
Copy link
Member

Hi @bachmanity1 and thanks for your interest in this project.

Your request seems legit to me and I agree that this is a good way to start contributing 🙂

Let me give you a pointer:

so that you have a rough idea on where to start (and the same in the v1beta1 package).

Let me know if you have any question!

@andreaTP andreaTP added enhancement component/crd-generator Related to the CRD generator labels Jul 19, 2023
@manusa manusa added this to the 6.8.0 milestone Jul 20, 2023
manusa pushed a commit that referenced this issue Jul 20, 2023
* add priority field to the PrinterColumn

* fix code style & update docs

* set default value for priority

* fix crd generator test

* fix decorator equals
manusa added a commit that referenced this issue Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/crd-generator Related to the CRD generator enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants