Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] CRDGenerator v2 #5948

Closed
shawkins opened this issue Apr 24, 2024 Discussed in #5942 · 2 comments · Fixed by #5949
Closed

[EPIC] CRDGenerator v2 #5948

shawkins opened this issue Apr 24, 2024 Discussed in #5942 · 2 comments · Fixed by #5949
Labels
Milestone

Comments

@shawkins
Copy link
Contributor

shawkins commented Apr 24, 2024

Discussed in #5942

We've decided to commit a v2 implementation of the crd generator along side the existing one so that it can be part of fabric8 6.

Tasks

@shawkins shawkins added the component/crd-generator Related to the CRD generator label Apr 24, 2024
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Apr 24, 2024
closes: fabric8io#5948

also removes v1beta1 from the new code
@manusa manusa added this to the 6.13.0 milestone May 3, 2024 — with automated-tasks
manusa pushed a commit that referenced this issue May 3, 2024
feature: add a v2 crd generator based on jackson

closes: #5948

also removes v1beta1 from the new code
---
fixing formatting
---
fully removing v1beta1 and ordering required
---
accepting the change in the printer column type

also removing another reference to CustomResource
---
removing erroneous v1 changes
---
removing decorator classes
---
wiring up new top level options
---
removing deprecated method, adding another test
---
Update crd-generator/api-v2/src/main/java/io/fabric8/crdv2/generator/AbstractJsonSchema.java

Co-authored-by: Bernhard Strähle <[email protected]>
---
Update crd-generator/api-v2/src/main/java/io/fabric8/crdv2/generator/v1/CustomResourceHandler.java

Co-authored-by: Bernhard Strähle <[email protected]>
---
finishing off review changes and adding a test
---
Merge branch 'main' of github.com:fabric8io/kubernetes-client into crd-generator-v7-development
---
replacing the YAML_MAPPER with standard serialization
---
adding back a common method for printer columns

also using string instead of object or array types
---
adding back dependent class names
---
stripping the explicit start
---
removing unnecessary override
@manusa manusa reopened this May 6, 2024
@manusa manusa modified the milestones: 6.13.0, 7.0.0 May 29, 2024
Copy link

stale bot commented Aug 28, 2024

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Aug 28, 2024
@manusa manusa changed the title CRD-Generator v2 [EPIC] CRD-Generator v2 Aug 28, 2024
@manusa
Copy link
Member

manusa commented Nov 25, 2024

closing since I mistakenly duplicated it in #6616 which is no more up to date.

@manusa manusa closed this as completed Nov 25, 2024
@manusa manusa changed the title [EPIC] CRD-Generator v2 [EPIC] CRDGenerator v2 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants