Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parallel processing with crd-generator v2 #5952

Closed
shawkins opened this issue Apr 24, 2024 · 3 comments
Closed

Enable parallel processing with crd-generator v2 #5952

shawkins opened this issue Apr 24, 2024 · 3 comments
Assignees
Labels
component/crd-generator Related to the CRD generator

Comments

@shawkins
Copy link
Contributor

The v2 generator will need to be parallized at the clazz level.

There will need to be a ResolvingContext instance for each usage - the SchemaGenerator isn't thread-safe. But they could all share the "seen" Jackson schema instances so that any common classes would not need to be re-resolved.

@shawkins shawkins added the component/crd-generator Related to the CRD generator label Apr 24, 2024
@shawkins shawkins self-assigned this Apr 26, 2024
Copy link

stale bot commented Jul 26, 2024

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Jul 26, 2024
@stale stale bot closed this as completed Aug 3, 2024
@manusa manusa reopened this Aug 5, 2024
@stale stale bot removed the status/stale label Aug 5, 2024
@baloo42
Copy link
Contributor

baloo42 commented Sep 8, 2024

I think this feature has already been implemented with #5949:

https://github.com/fabric8io/kubernetes-client/blob/main/crd-generator/api-v2/src/main/java/io/fabric8/crdv2/generator/CRDGenerator.java#L194

Parallel execution is also enabled by default in the maven plugin and in the CLI.

@shawkins
Copy link
Contributor Author

shawkins commented Sep 9, 2024

@baloo42 looks like we're good to resolve this properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/crd-generator Related to the CRD generator
Projects
None yet
Development

No branches or pull requests

3 participants