Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Rework MessageBus configuration for all services to use consistently #410

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Jan 10, 2023

BREAKING CHANGE: MessageQueue renamed to MessageBus and fields changed. See v3 Migration guide.

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    TBD

Testing Instructions

See follow on PRs for edgex-go

New Dependency Instructions (If applicable)

…nsitantly

BREAKING CHANGE: MessageQueue renamed to MessageBus and fields changed. See v3 Migration guide.

Signed-off-by: Leonard Goodell <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #410 (66aa4df) into main (cd249ec) will decrease coverage by 0.08%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   59.40%   59.32%   -0.09%     
==========================================
  Files          24       24              
  Lines        1685     1689       +4     
==========================================
+ Hits         1001     1002       +1     
- Misses        640      642       +2     
- Partials       44       45       +1     
Impacted Files Coverage Δ
config/types.go 35.29% <ø> (ø)
bootstrap/handlers/messaging.go 79.22% <84.21%> (-2.98%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lenny-goodell lenny-goodell merged commit 3599fd1 into edgexfoundry:main Jan 10, 2023
@lenny-goodell lenny-goodell deleted the mb-config branch January 10, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants