refactor!: Rework code for refactored MessageBus Configuration #4268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
force-pushed
the
mb-config-refactor
branch
from
74e03dd to
38b0d54
Compare
lenny-goodell
changed the title
lenny-goodell
force-pushed
the
mb-config-refactor
branch
from
38b0d54 to
2b45e66
Compare
lenny-goodell
force-pushed
the
mb-config-refactor
branch
2 times, most recently
from
076b5ec to
f6f0266
Compare
jim-wang-intel
previously approved these changes
Jan 10, 2023
lenny-goodell
force-pushed
the
mb-config-refactor
branch
from
f6f0266 to
8df0c0f
Compare
lenny-goodell
force-pushed
the
mb-config-refactor
branch
2 times, most recently
from
c00490a to
7112bdb
Compare
lenny-goodell
force-pushed
the
mb-config-refactor
branch
2 times, most recently
from
82ebe90 to
fee97dc
Compare
Merged
3 tasks
lenny-goodell
force-pushed
the
mb-config-refactor
branch
from
fee97dc to
2a06898
Compare
BREAKING CHANGE: MessageQueue renamed to MessageBus and fields changed. See v3 Migration guide. Signed-off-by: Leonard Goodell <[email protected]>
lenny-goodell
force-pushed
the
mb-config-refactor
branch
from
2a06898 to
12c96ac
Compare
Signed-off-by: Leonard Goodell <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
jim-wang-intel
approved these changes
Jan 11, 2023
bnevis-i
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: MessageQueue renamed to MessageBus and fields changed. See v3 Migration guide.
This PR is dependent on edgexfoundry/go-mod-bootstrap#410
Signed-off-by: Leonard Goodell [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)TBD
Testing Instructions
Run non-secure Edgex Stack with device virtual and stop all core/support services.
Build core/support services locally
Run core/support services locally with DEBUG log level
Verify core/support services bootstrap properly and connect to the MessageBus
Verify Core Data is receiving events.
New Dependency Instructions (If applicable)