-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tag-expressions-python: Prepare release v4.0.1 #1745
tag-expressions-python: Prepare release v4.0.1 #1745
Conversation
* Prepare for next release * FIXES cucumber#1736 (with pull-request: cucumber#1742) * tox: Update to newer Python versions
I see that a release has been made for python but not the other implementations. All implementations share a version number. To avoid problems in the future can you make a release of the other implementations too? |
@mpkorstanje |
Even if a patch only affects one implementation all implementations get a new release. This helps keep things simple. As we don't have to wonder about the available version numbers for each implementation. If you use the make file it does not take any extra effort. https://github.com/cucumber/common/blob/main/RELEASE_PROCESS.md Can I assume you did not use the make file? |
I second what @mpkorstanje said. Following the release process also creates a tag in git, and updates the changelog with links to the released version and adds a new section for the next version. Right now it is not obvious in the changelog and git tags that a 4.0.1 release has been made. |
@jenisys It is nice to see you back there! Thank you for your contribution. As you may have noticed, python implementation of The python package seems not to have been actually released, but simply pre-released as the name of the PR suggest: https://pypi.org/project/cucumber-tag-expressions/#history Could you confirm? @mpkorstanje where did you see a release for that module? When I check your changes, it looks like the Makefile for python are missing some places where to update the version number: And please, don't worry for that release thing. If any mistake has been made, that's not a big deal. It happens to everybody. Do not be afraid to contribute again! |
I released the Python packages but noticed that there is still a flaw in the README that is used for the package description (I fixed the flaw but I have not pushed it back to the repo). Therefore, I removed the release afterwards. Due to this removal, the package cannot be republished with version NOTES:
|
Ok, thank you for the details. I will take a look on that today, trying to release tag-expressions 4.0.2 for all implementations. And I'll take a look on the makefiles then |
tag-expressions has been released as 4.0.2 The |
This will be a lot simpler once we move the code to a new |
Yes, I guess so Once again @jenisys, thanks for your contribution! I hope to see you more often to take care of the python port! 🤩 |
Hi @jenisys - completely unrelated to this - would you be interested in trying to grow the behave contributor community? @aurelien-reeves and I have been talking to @bbelderbos and @blaisep about coaching the pybit.es community towards making contributions to behave :-) |
Summary
Perform some cleanups and updates before a new release of this package can be published on https://pypi.org .
Details
tox.ini
to use newer Python versionsPATCH RELEASE CONTAINS:
setuptools >= 58.0.2
)Motivation and Context
Prepare for next release of
tag-expressions-python
.How Has This Been Tested?
Normal test suite was run with tox.
BUT: Only cosmetic changes were performed here.
Types of changes
Checklist: