Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cucumber-tag-expressions install failing on newer versions of setuptools #1736

Closed
krisgesling opened this issue Sep 8, 2021 · 0 comments · Fixed by #1742 or #1745
Closed

cucumber-tag-expressions install failing on newer versions of setuptools #1736

krisgesling opened this issue Sep 8, 2021 · 0 comments · Fixed by #1742 or #1745
Labels
🏦 debt Tech debt 💔 breaking change This will require a major release 🐛 bug Defect / Bug language: python 🙏 help wanted Help wanted - not prioritized by core team

Comments

@krisgesling
Copy link
Contributor

Describe the bug
I'm starting to see pip install failures in Github Actions due to the use of use_2to3 in cucumber-tag-expressions. Setuptools deprecated use of use_2to3 from v58 (see changelog).

So an alternative approach will be needed, or dropping support for Python 2. Figured this is a call for the maintainers hence an issue rather than a PR.

Thanks for a great package though :)

To Reproduce

pip install setuptools>=58.0.0
pip install cucumber-tag-expressions

See error:

Collecting cucumber-tag-expressions
  Downloading cucumber-tag-expressions-4.0.0.tar.gz (32 kB)
    ERROR: Command errored out with exit status 1:
     command: /home/gez/git/.venv/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-8upi3hmn/cucumber-tag-expressions/setup.py'"'"'; __file__='"'"'/tmp/pip-install-8upi3hmn/cucumber-tag-expressions/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-8upi3hmn/cucumber-tag-expressions/pip-egg-info
         cwd: /tmp/pip-install-8upi3hmn/cucumber-tag-expressions/
    Complete output (3 lines):
    /home/gez/git/.venv/lib/python3.8/site-packages/setuptools/dist.py:717: UserWarning: Usage of dash-separated 'upload-dir' will not be supported in future versions. Please use the underscore name 'upload_dir' instead
      warnings.warn(
    error in cucumber-tag-expressions setup command: use_2to3 is invalid.
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

Expected behavior
Should successfully install using newer versions of setuptools.

Context & Motivation
Discovered this as our Github Actions started failing - hence we need to actively downgrade setuptools in 3rd party CI systems or fork the cucumber package and remove use_2to3.

Your Environment
Replicated on

  • Ubuntu 21.04
  • Github Actions
@aurelien-reeves aurelien-reeves added 🏦 debt Tech debt 💔 breaking change This will require a major release 🐛 bug Defect / Bug 🙏 help wanted Help wanted - not prioritized by core team language: python library: tag-expressions labels Sep 8, 2021
krisgesling added a commit to krisgesling/common that referenced this issue Sep 9, 2021
Method has been deprecated in setuptools>=58.0.0
Fixes cucumber#1736
krisgesling added a commit to krisgesling/common that referenced this issue Sep 9, 2021
Method has been deprecated in setuptools>=58.0.0
Fixes cucumber#1736
krisgesling added a commit to krisgesling/common that referenced this issue Sep 9, 2021
Method has been deprecated in setuptools>=58.0.0
Fixes cucumber#1736
jenisys added a commit that referenced this issue Sep 12, 2021
HINT: Method has been deprecated since setuptools >= 58.0.0
Fixes #1736

Co-authored-by: jenisys <[email protected]>
jenisys added a commit to jenisys/cucumber that referenced this issue Sep 12, 2021
* Prepare for next release
* FIXES cucumber#1736 (with pull-request: cucumber#1742)
* tox: Update to newer Python versions
jenisys added a commit that referenced this issue Sep 12, 2021
Prepare for next release: `v4.0.1`

* BUMP-VERSION: 4.0.1 (was: 4.0.0)
* tox: Update to newer Python versions

FIXES:
* FIXES #1736 (with pull-request: #1742)

OTHERWISE:
* FIX: Incorrect version info
* FIX README: Badge for CI build server status (was: Travis, but is now: CircleCI)
* FIX README: Badge was using wrong LICENSE information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏦 debt Tech debt 💔 breaking change This will require a major release 🐛 bug Defect / Bug language: python 🙏 help wanted Help wanted - not prioritized by core team
Projects
None yet
2 participants