externalconn,amazon: support s3 KMS in External Connecetions #86402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
adityamaru
force-pushed
the
s3-kms
branch
2 times, most recently
from
2dd9389 to
8da6b9d
Compare
adityamaru
requested review from
a team,
rhu713 and
benbardin
and removed request for
a team and
rhu713
benbardin
approved these changes
Aug 22, 2022
Informs: cockroachdb#84228 Release note (sql change): Users can now `CREATE EXTERNAL CONNECTION` to represent an `aws-kms` scheme that represents an AWS KMS resource.
|
Passing cloud unit test run - https://teamcity.cockroachdb.com/viewLog.html?buildId=6192738&buildTypeId=Cockroach_Nightlies_CloudUnitTests The flake is similar to #86616. bors r=benbardin |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs: #84228
Release note (sql change): Users can now
CREATE EXTERNAL CONNECTIONto represent anaws-kmsscheme that represents an AWS KMS resource.
Release justification: low risk change to new functionality to register s3 KMS as a supported External Connection