Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeedccl: context cancelled in changefeed tests #86616

Closed
jayshrivastava opened this issue Aug 22, 2022 · 3 comments
Closed

changefeedccl: context cancelled in changefeed tests #86616

jayshrivastava opened this issue Aug 22, 2022 · 3 comments
Assignees
@jayshrivastava
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cdc

Comments

@jayshrivastava
Copy link
Contributor

jayshrivastava commented Aug 22, 2022 •
edited by exalate-issue-sync bot
Loading

TestChangefeedColumnDropsOnMultipleFamiliesWithTheSameName flaked due to context cancellation

another flake in TestNoStopAfterNonTargetColumnDrop

another flake in TestChangefeedPrimaryKeyChangeWorks

another flake in TestChangefeedReplanning

Jira issue: CRDB-18841

Epic CRDB-11732
@jayshrivastava jayshrivastava added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-cdc Change Data Capture labels Aug 22, 2022
@jayshrivastava jayshrivastava self-assigned this Aug 22, 2022
@blathers-crl blathers-crl bot added the T-cdc label Aug 22, 2022
@blathers-crl
Copy link

blathers-crl bot commented Aug 22, 2022

cc @cockroachdb/cdc

@adityamaru adityamaru mentioned this issue Aug 22, 2022
Merged
@jayshrivastava jayshrivastava changed the title changefeedccl: context cancelled in TestChangefeedColumnDropsOnMultipleFamiliesWithTheSameName/sinkless changefeedccl: context cancelled in changefeed schema tests Aug 23, 2022
@HonoreDB
Copy link
Contributor

These are failing on multiple sinks so I'd bet the fix is to use requireErrorSoon whenever asserting an error from a schema change, and probably also skipping under stress and/or race.

@jayshrivastava jayshrivastava changed the title changefeedccl: context cancelled in changefeed schema tests changefeedccl: context cancelled in changefeed tests Aug 24, 2022
@jayshrivastava
Copy link
Contributor Author

#86794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayshrivastava jayshrivastava

Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cdc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HonoreDB @jayshrivastava