Devops/adding eventbridge #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating to use var instead of id
service/task/exec
* adding autoscaling capabilites * removing ecs cluster name var
* adding autoscaling capabilites * removing ecs cluster name var * fixing resource instance key * fixing resource instance key
* adding autoscaling capabilites * removing ecs cluster name var * fixing resource instance key * fixing resource instance key * adding count attribute for role
* adding autoscaling capabilites * removing ecs cluster name var * fixing resource instance key * fixing resource instance key * adding count attribute for role * adding count attribute
…resource (#7) * adding autoscaling capabilites * removing ecs cluster name var * fixing resource instance key * fixing resource instance key * adding count attribute for role * adding count attribute * removing role arn, not needed * changing back to name
* adding autoscaling capabilites * removing ecs cluster name var * fixing resource instance key * fixing resource instance key * adding count attribute for role * adding count attribute * removing role arn, not needed * changing back to name * updating to use ecs_service_name instead of mod name
* adding autoscaling capabilites * removing ecs cluster name var * fixing resource instance key * fixing resource instance key * adding count attribute for role * adding count attribute * removing role arn, not needed * changing back to name * updating to use ecs_service_name instead of mod name * remove weird formatting for task policy arns * testing new family setup and removing weird formatting * testing tag updates * updating container def tags * testing attributes * just going to use tags * reverting formatting
* adding lifecycle event to ignore task def, desired count, and load balancer changes * Revert "adding lifecycle event to ignore task def, desired count, and load balancer changes" This reverts commit 683eccc. * asking terraform to ignore changes to load balancer when blue/green deploys happen
* updating resource id service name ref * using try to catch false and true situations for service name
* adding sg_name for dot-com * changing empty string to null --------- Co-authored-by: Monica Hart <[email protected]>
Co-authored-by: Monica Hart <[email protected]>
|
💥 This pull request now has conflicts. Could you fix it @Mhart12? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This adds IAM and EventBridge resources in order for CodeDeploy to trigger new deployment based on the default task definition in ECS.
why
So we don't have to manually trigger CodeDeploys
references
https://kininsurance.atlassian.net/browse/DK-824