Updating family to use ecs_service_name var #8
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervice-task into adding-autoscaling
…ervice-task into adding-autoscaling
…ervice-task into adding-autoscaling
…ervice-task into adding-autoscaling
brookeconnell
approved these changes
Jan 17, 2024
natw
reviewed
Jan 17, 2024
| @@ -51,7 +51,7 @@ module "exec_label" { | |||
|
|
|||
| resource "aws_ecs_task_definition" "default" { | |||
| count = local.create_task_definition ? 1 : 0 | |||
| family = module.this.name | |||
| family = var.ecs_service_name | |||
There was a problem hiding this comment.
ecs_service_name isn't a required variable, and can be null.
If you want this the same as the service name (probably a good idea), make sure you're setting it to the same things as the service name. In this case, that would be var.ecs_service_name != null ? var.ecs_service_name : module.this.id
Though looking at it again, I think that should actually be module.service_label.id (both here and in the actual aws_ecs_service resource definition further down. service_label sets label_order to ["name", "attributes"], so two service task modules with the same "name" but different attributes (ie "web" vs "worker") should have things named uniquely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
The module.this.name worked for the web apps, but not for the workers. So by updating this, we'll be able to tie the ECS service name to the container definition instead of the module name. Because the web and worker technically use the same module.
why
So we don't mess up worker family names.
references
https://kininsurance.atlassian.net/browse/DK-389