Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set babel target to node 4 instead of current #19

Merged
merged 1 commit into from
Jul 5, 2017
Merged

Set babel target to node 4 instead of current #19

merged 1 commit into from
Jul 5, 2017

Conversation

sudo-suhas
Copy link
Collaborator

@sudo-suhas sudo-suhas commented Jul 5, 2017 •
edited
Loading

Keeping the babel-preset-env target as "current" means that the generated files depend on the node process version. Instead set target to "4" to avoid this issue.

Closes #17.

@asfktz
Copy link
Owner

asfktz commented Jul 5, 2017

Yeah, that's true.
I use current for debugging with devtools, but for the rest of the world... yes.

@asfktz asfktz merged commit 648685d into asfktz:master Jul 5, 2017
@sudo-suhas sudo-suhas deleted the build_target_node_4 branch July 5, 2017 15:30
@sudo-suhas sudo-suhas mentioned this pull request Jul 6, 2017
Closed
@asfktz asfktz added this to the 0.0.8 milestone Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@sudo-suhas @asfktz