Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example cannot be run with node 4 #16

Closed
sudo-suhas opened this issue Jul 5, 2017 · 5 comments
Closed

Example cannot be run with node 4 #16

sudo-suhas opened this issue Jul 5, 2017 · 5 comments
Labels

Comments

@sudo-suhas
Copy link
Collaborator

If I try to run the recommended example with node 4, the following happens:

λ npm install
npm WARN package.json [email protected] No description
npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] No README data
npm WARN unmet dependency E:\Projects\repos\autodll-webpack-plugin\examples\recommended\node_modules\html-webpack-plugin\node_modules\pretty-error\node_modules\renderkid requires utila@'~0.3' but will load
npm WARN unmet dependency E:\Projects\repos\autodll-webpack-plugin\examples\recommended\node_modules\html-webpack-plugin\node_modules\pretty-error\node_modules\utila,
npm WARN unmet dependency which is version 0.4.0
npm WARN unmet dependency E:\Projects\repos\autodll-webpack-plugin\examples\recommended\node_modules\webpack-dev-server\node_modules\http-proxy-middleware\node_modules\micromatch requires is-glob@'^2.0.1' but will load
npm WARN unmet dependency E:\Projects\repos\autodll-webpack-plugin\examples\recommended\node_modules\webpack-dev-server\node_modules\http-proxy-middleware\node_modules\is-glob,
npm WARN unmet dependency which is version 3.1.0
npm ERR! Windows_NT 6.2.9200
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! node v4.8.0
npm ERR! npm  v2.15.11
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package [email protected] does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer [email protected] wants webpack@1 || ^2 || ^2.1.0-beta || ^2.2.0-rc || ^3
npm ERR! peerinvalid Peer [email protected] wants webpack@^2.2.0

I don't think this is a big deal but maybe mention the compatible node version in the readme? You could also include a engines key in package.json like so:

{
  // ...
  "engines": {
    "node": ">= 6.9.2",
    "npm": ">= 3.10.9"
  },
}
@sudo-suhas
Copy link
Collaborator Author

Sorry.. Closed the wrong one

@sudo-suhas sudo-suhas reopened this Jul 5, 2017
@GrimDev
Copy link

GrimDev commented Jul 6, 2017

Hi !
Same kind of problem in node 4.2.4 that doesn't support ES2015 destructuring apparently used in this module.
Got a SyntaxError in the file : plugin.js (let { entry } = _ref).

I will upgrade my nodejs soon to fix this problem but it would have been nicer if the lowest supported node version had been written in the README or appears in package.json.
Could you please explicit the compatibility somewhere ?

Thanks you.

@sudo-suhas
Copy link
Collaborator Author

@GrimDev As it happens, this issue of not being to use the module with node v4 was identified(#17) and fixed(#19) already. However, due to an oversight, the package version 0.0.8 was not published to npm. I have created an issue for the same - #29. It should be resolved soon. But you are quite right, the compatibility should be explicitly mentioned.

@asfktz asfktz added the bug label Jul 6, 2017
@asfktz
Copy link
Owner

asfktz commented Jul 10, 2017

@sudo-suhas is it still relevant?

@sudo-suhas
Copy link
Collaborator Author

I was able to run the example on node v4.8.0. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants