Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trafficrouting): add nil check for desired annotations map in ALB… #3853

Merged
merged 1 commit into from
Sep 27, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions rollout/trafficrouting/alb/alb.go
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,9 @@
if err != nil {
return nil, err
}
if desired == nil {
desired = make(map[string]string)

Check warning on line 413 in rollout/trafficrouting/alb/alb.go

View check run for this annotation

Codecov / codecov/patch

rollout/trafficrouting/alb/alb.go#L413

Added line #L413 was not covered by tests
}
desired[key] = value
return modifyManagedAnnotation(desired, r.Name, true, key)
}
Expand Down
Loading