fix(trafficrouting): add nil check for desired annotations map in ALB… #3853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ingress Signed-off-by: Youssef Rabie <[email protected]>
|
Published E2E Test Results 4 files 4 suites 3h 14m 47s ⏱️ For more details on these failures, see this check. Results for commit 1884643. |
Published Unit Test Results2 275 tests 2 275 ✅ 2m 59s ⏱️ Results for commit 1884643. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3853 +/- ##
==========================================
- Coverage 83.86% 83.84% -0.02%
==========================================
Files 163 163
Lines 18560 18562 +2
==========================================
- Hits 15565 15563 -2
- Misses 2121 2123 +2
- Partials 874 876 +2 ☔ View full report in Codecov by Sentry. |
zachaller
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".Bug description
Sometimes, the argo-rollouts controller goes into a loop of panicking/recovering from panic when creating a new Rollout object.
The Rollout object is created and is stuck in the
Progressingstate, the replicaset is created as well, except that it's stuck with.spec.replicas= 0.To Reproduce
To reproduce, create any simple Rollout object that references an ALB ingress. Make sure that the ingress has no annotations present on it (this is not the case when applying through
kubectl, since akubectl.kubernetes.io/last-applied-configurationis added by default. This is the case however when creating through, for example, ArgoCD, with no desired annotations of mine to add.You can create through
kubectland manually delete the annotation before creating the Rollout object referencing the ingress to test the behavior.This is currently happening on the latest v1.7.2
Logs
Testing
I have built the image and tested the behavior and it's working as expected.