remove service:info command #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I have no issue with this, but it looks like @jbaxleyiii added this command. Might run this by him just in case he has any plans for it.
This removes the `apollo service:info` command. Currently `apollo service:info` is not in the documentation. Additionally the information for a service is inside of the Apollo UI, so this command adds unnecessary noise. Additionally, the command has only been called [once in the last year](https://engine-staging.apollographql.com/service/engine/metrics?from=2018-04-17T23%3A25%3A00.000Z&query=5b4a5cb5ae6ed5af6c3b0422a31bda82cd12ca20&queryName=SchemaTagInfo&range=custom&schemaTag=prod&search=SchemaTagInfo&to=2019-05-17T23%3A25%3A00.000Z), so I suggest we make this a non-breaking change.
evans
force-pushed
the
evans/remove-service-info
branch
from
5b823d8 to
2da1b22
Compare
|
The command was used for internal platform usage according to @jbaxleyiii, so we can remove it! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
apollo service:infocommand. Currentlyapollo service:infois not in the documentation. Additionally the information for a service is inside of the Apollo UI, so this command adds unnecessary noise.Additionally, the command has only been called once in the last
year, so I suggest we make this a non-breaking change.