Skip to content

Commit

Permalink
remove service:info command (#1274)
Browse files Browse the repository at this point in the history
* service:info remove command

This removes the `apollo service:info` command. Currently `apollo
service:info` is not in the documentation. Additionally the information
for a service is inside of the Apollo UI, so this command adds
unnecessary noise.

Additionally, the command has only been called [once in the last
year](https://engine-staging.apollographql.com/service/engine/metrics?from=2018-04-17T23%3A25%3A00.000Z&query=5b4a5cb5ae6ed5af6c3b0422a31bda82cd12ca20&queryName=SchemaTagInfo&range=custom&schemaTag=prod&search=SchemaTagInfo&to=2019-05-17T23%3A25%3A00.000Z),
so I suggest we make this a non-breaking change.

* update changelog

* update graphql types
  • Loading branch information
evans authored May 20, 2019
1 parent 3125d51 commit 7b22548
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 139 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- `apollo`
- Add debugging logs to `apollo client:push` and `apollo service:push` [# 1273](https://github.com/apollographql/apollo-tooling/pull/1273)
- remove `apollo service:info` command, since it's undocumented and unused [#1274](https://github.com/apollographql/apollo-tooling/pull/1274)
- `apollo-codegen-core`
- <First `apollo-codegen-core` related entry goes here>
- `apollo-codegen-flow`
Expand Down
10 changes: 0 additions & 10 deletions packages/apollo-language-server/src/engine/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,11 @@ import {
ValidateOperations,
ValidateOperationsVariables,
SchemaTagsAndFieldStats,
SchemaTagInfo,
SchemaTagInfoVariables,
CheckPartialSchema,
CheckPartialSchemaVariables,
RemoveServiceAndCompose,
RemoveServiceAndComposeVariables
} from "../graphqlTypes";
import { SCHEMA_TAG_INFO_QUERY } from "./operations/schemaTagInfo";

export interface ClientIdentity {
name?: string;
Expand Down Expand Up @@ -278,11 +275,4 @@ export class ApolloEngineClient extends GraphQLDataSource {

return { schemaTags, fieldStats };
}

public async schemaTagInfo(variables: SchemaTagInfoVariables) {
return this.execute<SchemaTagInfo>({
query: SCHEMA_TAG_INFO_QUERY,
variables
});
}
}

This file was deleted.

49 changes: 0 additions & 49 deletions packages/apollo-language-server/src/graphqlTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -327,55 +327,6 @@ export interface RemoveServiceAndComposeVariables {
/* eslint-disable */
// This file was automatically generated and should not be edited.

// ====================================================
// GraphQL query operation: SchemaTagInfo
// ====================================================

export interface SchemaTagInfo_service_schema_gitContext {
__typename: "GitContext";
committer: string | null;
commit: string;
}

export interface SchemaTagInfo_service_schema {
__typename: "Schema";
hash: string;
gitContext: SchemaTagInfo_service_schema_gitContext | null;
/**
* The number of fields; this includes user defined fields only, excluding built-in types and fields
*/
fieldCount: number;
/**
* The number of types; this includes user defined types only, excluding built-in types
*/
typeCount: number;
createdAt: any;
}

export interface SchemaTagInfo_service {
__typename: "Service";
/**
* Get a schema by hash OR current tag
*/
schema: SchemaTagInfo_service_schema | null;
}

export interface SchemaTagInfo {
/**
* Service by ID
*/
service: SchemaTagInfo_service | null;
}

export interface SchemaTagInfoVariables {
service: string;
tag?: string | null;
}

/* tslint:disable */
/* eslint-disable */
// This file was automatically generated and should not be edited.

// ====================================================
// GraphQL query operation: SchemaTagsAndFieldStats
// ====================================================
Expand Down
62 changes: 0 additions & 62 deletions packages/apollo/src/commands/service/info.ts

This file was deleted.

0 comments on commit 7b22548

Please sign in to comment.