Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yagiz/implement url pattern #15

Open
wants to merge 81 commits into
base: main
Choose a base branch
from
Open

Yagiz/implement url pattern #15

wants to merge 81 commits into from

Conversation

anonrig
Copy link
Owner

@anonrig anonrig commented Dec 20, 2024

No description provided.

@anonrig anonrig requested a review from lemire December 20, 2024 21:05
@anonrig anonrig force-pushed the yagiz/implement-url-pattern branch from 5b4ae6b to ac1060f Compare December 20, 2024 21:26
legendecas and others added 3 commits December 21, 2024 11:02
@legendecas
module: use buffer.toString base64
4fd5db4 
`btoa` only supports latin-1 charset and produces invalid source
mapping urls.

PR-URL: nodejs#56315
Refs: nodejs#56296
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@aduh95
tools: add release line label when opening release proposal
821ab6f 
PR-URL: nodejs#56317
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@louwers
doc: add entry to changelog about SQLite Session Extension
b814038 
PR-URL: nodejs#56318
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@anonrig anonrig force-pushed the yagiz/implement-url-pattern branch 4 times, most recently from d6fd86b to b9adc10 Compare December 22, 2024 00:19
@zcbenz @jakecastelli
build: fix GN build for ngtcp2
31c20f6 
PR-URL: nodejs#56300
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@anonrig anonrig force-pushed the yagiz/implement-url-pattern branch 3 times, most recently from d3a020c to 276cf9a Compare December 22, 2024 18:00
aduh95 and others added 17 commits December 22, 2024 18:44
@aduh95
tools: fix require-common-first lint rule from subfolder
48c75bc 
PR-URL: nodejs#56325
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
@marco-ippolito
test: check typescript loader
56d5865 
PR-URL: nodejs#54657
Refs: nodejs#54645
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@nodejs-github-bot
deps: update simdutf to 5.7.0
6577166 
PR-URL: nodejs#56332
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@nodejs-github-bot
deps: update ngtcp2 to 1.10.0
270a2f1 
PR-URL: nodejs#56334
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@yiyunlei @marco-ippolito
test: migrate message eval tests from Python to JS
a9e65f6 
Migrate the eval tests in the `test/message` folder from Python to JS.

PR-URL: nodejs#50482
Reviewed-By: Juan José Arboleda <[email protected]>
@jakecastelli @nodejs-github-bot
Revert "stream: handle generator destruction from Duplex.from()"
6156f8a 
This reverts commit 5541300.

PR-URL: nodejs#56278
Reviewed-By: Matteo Collina <[email protected]>
@jakecastelli @jazelly @nodejs-github-bot
test: add coverage for pipeline
5ea6fa7 
co-authored-by: jazelly <[email protected]>
PR-URL: nodejs#56278
Reviewed-By: Matteo Collina <[email protected]>
@mhdawson
test: increase spin for eventloop test on s390
be9dc2d 
It was excluded as it was failing intermittently. Likely
that s390 was just so fast times were rounded down to 0.

Increase the spin time on s390x only.

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#56228
Refs: nodejs#41286
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@marco-ippolito
module: support eval with ts syntax detection
da3f388 
PR-URL: nodejs#56285
Refs: nodejs/typescript#17
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
@aduh95
test: skip test-sqlite-extensions when SQLite is not built by us
49acdc8 
PR-URL: nodejs#56341
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@kevinuehara
doc: fix the crc32 documentation
bd0b704 
PR-URL: nodejs#55898
Fixes: nodejs#55800
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@IlyasShabi
src: use starts_with in fs_permission.cc
821b0a7 
PR-URL: nodejs#55811
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
@targos
doc: update macOS and Xcode versions for releases
3147ec2 
This is just documenting the current state, not changing it.

PR-URL: nodejs#56337
Refs: https://ci-release.nodejs.org/job/iojs+release/10689/nodes=osx13-x64-release-tar/consoleFull
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@lpinca
test: deflake test-watch-file-shared-dependency
d00710d 
Delay dependency file modification on macOS.

Refs: nodejs#51842
PR-URL: nodejs#56344
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@mcollina
doc: clarify that WASM is trusted
7ca7531 
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: nodejs#56345
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@aduh95
doc: use <ul> instead of <ol> in SECURITY.md
f9fb410 
PR-URL: nodejs#56346
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@nodejs-github-bot
meta: move one or more collaborators to emeritus
b420c8f 
PR-URL: nodejs#56342
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@lpinca @jasnell
test: remove flaky test-pipe-file-to-http designation
72537f5 
The original issue is likely the same as other tests that time out.

Refs: nodejs#54918
Refs: nodejs#53595
Refs: nodejs#53751
PR-URL: nodejs#56472
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@anonrig anonrig force-pushed the yagiz/implement-url-pattern branch from af23313 to 41aa386 Compare January 6, 2025 17:57
@jasnell
src, quic: refine more of the quic implementation
062ae6f 
Signed-off-by: James M Snell <[email protected]>
PR-URL: nodejs#56328
Reviewed-By: Yagiz Nizipli <[email protected]>
@anonrig anonrig force-pushed the yagiz/implement-url-pattern branch from 41aa386 to 41e2894 Compare January 6, 2025 18:48
legendecas and others added 5 commits January 7, 2025 11:03
@legendecas
src: drain platform tasks before creating startup snapshot
52c6449 
Drain the loop and platform tasks before creating a snapshot. This is
necessary to ensure that the no roots are held by the the platform
tasks, which may reference objects associated with a context. For
example, a WeakRef may schedule an per-isolate platform task as a GC
root, and referencing an object in a context, causing an assertion in
the snapshot creator.

PR-URL: nodejs#56403
Refs: nodejs#56292
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@Xiao-Tao
tools: fix loong64 build failed
8c19a5c 
PR-URL: nodejs#56466
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@lpinca
test: remove test-macos-app-sandbox flaky designation
75b9c1c 
Fixes: nodejs#54811
Refs: nodejs#54811 (comment)
PR-URL: nodejs#56471
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
@joyeecheung
src: lock the thread properly in snapshot builder
7c3aa9f 
Otherwise it can crash DCHECK when V8 expects that at least someone
is locking the current thread.

PR-URL: nodejs#56327
Fixes: nodejs/node-v8#294
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@nodejs-github-bot @marco-ippolito
2025-01-07, Version 23.6.0 (Current)
36c53c6 
Notable changes:

lib:
  * (SEMVER-MINOR) add typescript support to STDIN eval (Marco Ippolito) nodejs#56359
module:
  * (SEMVER-MINOR) unflag --experimental-strip-types (Marco Ippolito) nodejs#56350
process:
  * (SEMVER-MINOR) add process.ref() and process.unref() methods (James M Snell) nodejs#56400
worker:
  * (SEMVER-MINOR) add eval ts input (Marco Ippolito) nodejs#56394

PR-URL: nodejs#56450
@anonrig anonrig force-pushed the yagiz/implement-url-pattern branch 2 times, most recently from e533cc7 to 0091c9c Compare January 7, 2025 19:33
@ruyadorno
2025-01-07, Version 22.13.0 'Jod' (LTS)
a344300 
Notable changes:

assert:
  * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630
cli:
  * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) nodejs#55604
crypto:
  * graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable (Filip Skokan) nodejs#56142
dgram:
  * (SEMVER-MINOR) support blocklist in udp (theanarkh) nodejs#56087
doc:
  * stabilize util.styleText (Rafael Gonzaga) nodejs#56265
  * move typescript support to active development (Marco Ippolito) nodejs#55536
  * add LJHarb to collaborators (Jordan Harband) nodejs#56132
  * (SEMVER-MINOR) add report version and history section (Chengzhong Wu) nodejs#56130
  * (SEMVER-MINOR) sort --report-exclude alphabetically (Rafael Gonzaga) nodejs#55788
doc,lib,src,test:
  * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890
module:
  * (SEMVER-MINOR) only emit require(esm) warning under --trace-require-module (Joyee Cheung) nodejs#56194
  * (SEMVER-MINOR) add module.stripTypeScriptTypes (Marco Ippolito) nodejs#55282
net:
  * (SEMVER-MINOR) support blocklist in net.connect (theanarkh) nodejs#56075
  * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) nodejs#56076
  * (SEMVER-MINOR) add net.BlockList.isBlockList(value) (James M Snell) nodejs#56078
  * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) nodejs#56079
process:
  * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) nodejs#55545
report:
  * (SEMVER-MINOR) fix typos in report keys and bump the version (Yuan-Ming Hsu) nodejs#56068
sqlite:
  * (SEMVER-MINOR) aggregate constants in a single property (Edigleysson Silva (Edy)) nodejs#56213
  * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213
src:
  * (SEMVER-MINOR) add cli option to preserve env vars on dr (Rafael Gonzaga) nodejs#55697
src,lib:
  * (SEMVER-MINOR) stabilize permission model (Rafael Gonzaga) nodejs#56201
util:
  * (SEMVER-MINOR) add sourcemap support to getCallSites (Marco Ippolito) nodejs#55589

PR-URL: nodejs#56329
@anonrig anonrig force-pushed the yagiz/implement-url-pattern branch from 0091c9c to d65e9f0 Compare January 7, 2025 20:39
jasnell and others added 7 commits January 7, 2025 21:08
@jasnell
src: make some minor ToLocalChecked cleanups
3b5f235 
PR-URL: nodejs#56483
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@jasnell
src: fixup more ToLocalChecked uses in node_file
8d9dac4 
PR-URL: nodejs#56484
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@aduh95
doc: fix faulty YAML metadata
5119049 
PR-URL: nodejs#56508
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@jasnell
crypto: make generatePrime/checkPrime interruptible
ea493c1 
The `generatePrime` and `checkPrime` functions in the `crypto`
module are only somewhat interruptible. This change makes it
possible to interrupt these more reliably. Note that generating
overly large primes can still take a long time and may not be
interruptible as this mechanism relies on a callback to check
for stopping conditions but OpenSSL may perform a long running
operation without calling the callback right away.

Fixes: nodejs#56449
PR-URL: nodejs#56460
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@puskin94
assert: show diff when doing partial comparisons
799d920 
PR-URL: nodejs#56211
Reviewed-By: Ruben Bridgewater <[email protected]>
@jasnell
src: move more crypto impl detail to ncrypto dep
c0ad193 
* remove obsolete LogSecret function
* move StackOfX509 decl to ncrypto
* colocate GetSSLOCSPResponse with callsite
* move x509 error code and reason to ncrypto
* simplify X509Pointer/X509View pointer derefs a bit
* move prime gen and checks to ncrypto
* move BN_* methods into ncrypto
* move SSLPointer impl to ncrypto
* move SSLCtxPointer impl to ncrypto
* move EVP_CIPHER methods to ncrypto
* move CipherCtx methods to ncrypto

PR-URL: nodejs#56421
Reviewed-By: Yagiz Nizipli <[email protected]>
@jasnell
src: minor cleanups on OneByteString usage
7b472fd 
* Provide a OneByteString variant that accepts std::string_view
* Use FIXED_ONE_BYTE_STRING in appropriate places

Signed-off-by: James M Snell <[email protected]>
PR-URL: nodejs#56482
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@anonrig anonrig force-pushed the yagiz/implement-url-pattern branch 8 times, most recently from 2dcb81a to ad8610c Compare January 8, 2025 16:47
@anonrig anonrig force-pushed the yagiz/implement-url-pattern branch from ad8610c to 261359f Compare January 8, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemire lemire Awaiting requested review from lemire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.