Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix loong64 build failed #56466

Merged
merged 1 commit into from
Jan 7, 2025
Merged

tools: fix loong64 build failed #56466

merged 1 commit into from
Jan 7, 2025

Conversation

Xiao-Tao
Copy link
Contributor

@Xiao-Tao Xiao-Tao commented Jan 4, 2025

Fix LoongArch64 build error
nodejs/unofficial-builds#154
#56280

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Jan 4, 2025
@Xiao-Tao Xiao-Tao mentioned this pull request Jan 4, 2025
Open
@Xiao-Tao
Copy link
Contributor Author

Xiao-Tao commented Jan 6, 2025

cc @shipujin

@shipujin
Copy link
Member

shipujin commented Jan 6, 2025 •
edited
Loading

Looks all right

LGTM

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64370/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6352/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6352/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6352/

lpinca
lpinca approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 6, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/64377/ 💛

@Xiao-Tao
Copy link
Contributor Author

Xiao-Tao commented Jan 7, 2025

Thank you so much!!! @shipujin @lpinca

@daeyeon daeyeon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 7, 2025
@jasnell jasnell added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jan 7, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2025
@nodejs-github-bot nodejs-github-bot merged commit 8c19a5c into nodejs:main Jan 7, 2025
76 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8c19a5c

@shipujin
Copy link
Member

Need to backport this patch to v22 and v23 branches @Xiao-Tao

@Xiao-Tao
Copy link
Contributor Author

@shipujin okay, very grateful.

@Xiao-Tao Xiao-Tao deleted the fix-loong64-build branch January 10, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Xiao-Tao @nodejs-github-bot @shipujin @jasnell @lpinca @richardlau @daeyeon