Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Asterisk spacer #449

Closed
wants to merge 1 commit into from
Closed

Asterisk spacer #449

wants to merge 1 commit into from

Conversation

jeryj
Copy link
Collaborator

@jeryj jeryj commented Sep 20, 2023

Description
Wrapping the spacer in a group block allows the asterisk to be colored via text group, aligned via the justification options, and has no semantic meaning so it is not announced by screen readers.

Screenshots
https://github.com/WordPress/twentytwentyfour/assets/967608/2c215560-036b-4757-8834-416776dc1dfd

Testing Instructions

  1. Add a group block
  2. Add a spacer to the group block
  3. Select Asterisk Style on the spacer style
  4. Change the color with the group block Text Color
  5. Change the alignment with the group block Justification
  6. Change the size of the asterisk with the group block Text sizes

Wrapping the spacer in a group block allows the asterisk to be colored via text group, aligned via the justification options, and has no semantic meaning so it is not announced by screen readers.
@scruffian
Copy link
Contributor

@MaggieCabrera @luminuu why was #471 chosen over this solution?

@MaggieCabrera
Copy link
Collaborator

@MaggieCabrera @luminuu why was #471 chosen over this solution?

Because it made more sense semantically that the asterisk is related to the heading. Also, it can be confusing for the users to have the asterisk on the spacer, it's not what you are expecting from this block. Besides the conversations spread all over the 3-4 PRs with alternatives for this I also had a conversation with @richtabor and he agreed that this was blurring the lines of what the block is for

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants