Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separator: Add ability to change HTML tag #54976

Closed
luminuu opened this issue Oct 2, 2023 · 0 comments · Fixed by #67530
Closed

Separator: Add ability to change HTML tag #54976

luminuu opened this issue Oct 2, 2023 · 0 comments · Fixed by #67530
Assignees
Labels
[Block] Separator Affects the Separator Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@luminuu
Copy link
Member

luminuu commented Oct 2, 2023

What problem does this address?

Traditionally, the separator block has been tied to the <hr> element, which is semantically correct. With the work on Twenty Twenty-Four, we've discovered that there's a need for adding a separator that is not announced by screen readers, when it's just a visual separator. The current solution is not the best one in TT4 either, as it uses the headings block and the visual separator can only be seen if a heading has content, to avoid the A11Y issue of having empty headings.

References:
WordPress/twentytwentyfour#522
WordPress/twentytwentyfour#449
WordPress/twentytwentyfour#471

What is your proposed solution?

Add a HTML tag selector to specifiy the element which should be used for the seperator, like it exists at the group block (div, main, section, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Separator Affects the Separator Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants