Separator block: Allow divs to be used as separators #67530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
ajitbohra,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Curious about your thoughts on this @jasmussen |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +176 B (+0.01%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
jorgefilipecosta
approved these changes
Dec 3, 2024
Mamaduka
reviewed
Dec 4, 2024
Mamaduka
reviewed
Dec 4, 2024
It seems advanced. I'm not against it, but it seems important that the default is useful to useful to screen readers. It seems like this default is likely to be unchanged by most theme authors unless they have fairly deep knowledge of the behavior. That's also an aegument to ensure this control lives in the "Advanced" section, like the tag selector for groups and the like. |
Mamaduka
reviewed
Dec 4, 2024
|
@youknowriad, you need to update this object to fix unit tests - it is just testing the block's edit component unit. gutenberg/packages/block-library/src/separator/test/edit.js Lines 21 to 26 in cc5a2b7 |
|
Looks like the native tests stopped working because we're using some old Mac image or something. |
It looks like. There's an old PR for update - #59070. |
ntsekouras
reviewed
Dec 4, 2024
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: luminuu <[email protected]>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: luminuu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #54976
What?
In some situations, you might want the separator blocks to not be announced by screen readers. You want them to be just design tokens. This PRs allows that by adding a "tagName" attribute to the separator block. Also adds a help text to explain when you should be using "divs".
Testing Instructions
1- Insert the separator block.
2- Under "Advanced" in the inspector panel, you can switch to "div".
3- Check that the separator still looks and behaves properly (we might want to check different themes, including classic ones)