Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gossip): improve gossip benchmarks #118

Merged
merged 10 commits into from
Apr 9, 2024

Conversation

0xNineteen
Copy link
Contributor

@0xNineteen 0xNineteen commented Apr 7, 2024

these benchmarks are much better at measure per-message-type performance in a reliable way

we also update the readme to remove blog-post content and include more code-operator information

this PR also relies on #117 to be merged first (we needed the updated gossip stats struct)


results on a macbook pro

Benchmark                                  Iterations    Min(ms)    Max(ms)   Variance   Mean(ms)
-------------------------------------------------------------------------------------------------
benchmarkGossipService(10k_ping_msgs)               1       1489       1489          0       1489
benchmarkGossipService(10k_push_msgs)               1      11811      11811          0      11811
benchmarkGossipService(10k_pull_resp_msgs)          1      11761      11761          0      11761

Benchmark                                   Iterations    Min(ms)    Max(ms)   Variance   Mean(ms)
--------------------------------------------------------------------------------------------------
benchmarkPullRequests(1k_data_1k_pull_reqs)           1        528        528          0        528
benchmarkPullRequests(10k_data_1k_pull_reqs)          1        575        575          0        575

@0xNineteen 0xNineteen force-pushed the 19/gossip_bench_improve branch from 4e5428c to d9e9499 Compare April 7, 2024 15:40
@0xNineteen 0xNineteen changed the base branch from main to 19/prometheus-counter-change April 7, 2024 15:44
@0xNineteen 0xNineteen changed the base branch from 19/prometheus-counter-change to main April 7, 2024 15:45
@0xNineteen 0xNineteen self-assigned this Apr 7, 2024
@0xNineteen 0xNineteen added this to the Gossip milestone Apr 7, 2024
@0xNineteen 0xNineteen changed the base branch from main to 19/prometheus-counter-change April 7, 2024 15:51
@0xNineteen 0xNineteen marked this pull request as ready for review April 7, 2024 15:53
@ultd ultd merged commit 08a6f92 into 19/prometheus-counter-change Apr 9, 2024
@ultd ultd deleted the 19/gossip_bench_improve branch April 9, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants