fix(gossip): update prometheus metric collection + dashboards #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xNineteen
force-pushed
the
19/prometheus-counter-change
branch
from
17cb5ba to
efed48f
Compare
added 2 commits
April 4, 2024 14:28
0xNineteen
force-pushed
the
19/prometheus-counter-change
branch
from
efed48f to
05dd559
Compare
…eus-counter-change
…dica/sig into 19/gossip_bench_improve
0xNineteen
commented
Apr 9, 2024
fix(gossip): improve gossip benchmarks
…dica/sig into 19/prometheus-counter-change
ultd
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this changes metric collection to be a continuously increasing counter with the logging included in the struct which is more inline with what prometheus expects
this also improves the grafana dashboards