Display filament labels in "change filament" context menus #4921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javawizard
force-pushed
the
jw/context-menu-filament-labels
branch
from
8084d36 to
29e03a9
Compare
|
FYI bambulab/BambuStudio#3830 has been merged into Bambu Studio. Happy to continue to see this PR over the line or close it if y'all pull in upstream changes from bambulab/BambuStudio on a frequent cadence - just let me know. |
SoftFever
approved these changes
Apr 10, 2024
powpingdone
pushed a commit
to powpingdone/OrcaSlicer
that referenced
this pull request
Apr 10, 2024
…#4921) * ENH: display filament labels in "change filament" context menus
powpingdone
pushed a commit
to powpingdone/OrcaSlicer
that referenced
this pull request
Apr 11, 2024
…#4921) * ENH: display filament labels in "change filament" context menus
SoftFever
pushed a commit
that referenced
this pull request
Apr 13, 2024
* ENH: display filament labels in "change filament" context menus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the actual filament labels in the "Change Filament" context menu instead of "Filament 1", "Filament 2", etc.
This makes it much quicker to tell what filament is being selected, especially when utilizing the "sync from AMS" button with a printer with several AMS units attached.
This is not yet tested due to #4920, but the corresponding PR I opened against Bambu Studio has been tested and works fine - both in the main view (which uses
append_menu_item_change_filament) and in the assemble view (which usesappend_menu_item_change_extruder), as well as with both built-in filament profiles and with user- and project-custom filament profiles.Before:
After: