Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes issue #410: 🐛 Fix startHour and endHour rebuild issue in WeekView #423

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

shubham-jitiya-simform
Copy link
Contributor

@shubham-jitiya-simform shubham-jitiya-simform commented Dec 4, 2024

Description

  • Fixed new startHour and endHour not updating.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #410

@shubham-jitiya-simform shubham-jitiya-simform marked this pull request as ready for review December 4, 2024 11:40
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the fix/issue_410_update_week_view_hours branch 3 times, most recently from f5e27ff to 45c34ad Compare December 16, 2024 06:48
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the fix/issue_410_update_week_view_hours branch 2 times, most recently from ad1a6b2 to a337314 Compare January 2, 2025 08:09
@shubham-jitiya-simform shubham-jitiya-simform force-pushed the fix/issue_410_update_week_view_hours branch from a337314 to 6ec0bf2 Compare January 2, 2025 11:32
@shubham-jitiya-simform shubham-jitiya-simform changed the title fix: Fixes issue #410: Fixed startHour and endHour rebuild issue in WeekView fix: Fixes issue #410: 🐛 Fix startHour and endHour rebuild issue in WeekView Jan 2, 2025
Copy link
Collaborator

@PRBaraiya PRBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PRBaraiya PRBaraiya merged commit af26492 into master Jan 2, 2025
1 check passed
@PRBaraiya PRBaraiya deleted the fix/issue_410_update_week_view_hours branch January 2, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing startHour and endHour doesn't update WeekView
2 participants