Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing startHour and endHour doesn't update WeekView #410

Closed
ValentinRegnault opened this issue Sep 27, 2024 · 0 comments · Fixed by #423
Closed

Changing startHour and endHour doesn't update WeekView #410

ValentinRegnault opened this issue Sep 27, 2024 · 0 comments · Fixed by #423
Assignees
Labels
bug Something isn't working priority:1 Bug/Enhancement with highest priority.

Comments

@ValentinRegnault
Copy link

ValentinRegnault commented Sep 27, 2024

WeekView(
  key: _weekViewKey,
  controller: _eventController,
  pageViewPhysics: const ClampingScrollPhysics(),
  startHour: _computeStartHour(),
  endHour: _computeEndHour(),
)

When the widget rebuilds with a new startHour and endHour, the widget stay the same.

I looked into the code and did the following changes in src/week_view/week_view.dart :

461 +    _startHour = widget.startHour;
462 +   _endHour = widget.endHour;
463    _calculateHeights();

And it works like a charm !

@PRBaraiya PRBaraiya added bug Something isn't working priority:1 Bug/Enhancement with highest priority. labels Nov 29, 2024
@shubham-jitiya-simform shubham-jitiya-simform self-assigned this Dec 5, 2024
PRBaraiya added a commit that referenced this issue Jan 2, 2025
…ate_week_view_hours

fix: Fixes issue #410: 🐛 Fix `startHour` and `endHour` rebuild issue in WeekView
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:1 Bug/Enhancement with highest priority.
Projects
None yet
3 participants