-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add [D2DGeneratedPixelShaderDescriptor] attribute and use FAWMN #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
optimization 🚀
Performance improvement to existing APIs
breaking change 💣
A change that is either binary or source breaking
labels
Oct 1, 2023
Sergio0694
force-pushed
the
dev/generated-marshaller-attribute
branch
from
October 1, 2023 14:37
cd7f94c
to
2daca71
Compare
Hey @Youssef1313, feel free to take a quick look if you feel like it! I've added a new code fixer in this one 😄 |
Youssef1313
reviewed
Oct 1, 2023
src/ComputeSharp.D2D1.CodeFixers/MissingPixelShaderDescriptorOnPixelShaderCodeFixer.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Oct 1, 2023
src/ComputeSharp.D2D1.CodeFixers/MissingPixelShaderDescriptorOnPixelShaderCodeFixer.cs
Outdated
Show resolved
Hide resolved
Sergio0694
force-pushed
the
dev/generated-marshaller-attribute
branch
from
October 1, 2023 15:57
2daca71
to
bbf6607
Compare
Sergio0694
force-pushed
the
dev/generated-marshaller-attribute
branch
from
October 1, 2023 19:39
1a15d34
to
462d724
Compare
Sergio0694
force-pushed
the
dev/generated-marshaller-attribute
branch
from
October 2, 2023 01:22
145612f
to
1029ad2
Compare
Sergio0694
force-pushed
the
dev/generated-marshaller-attribute
branch
2 times, most recently
from
October 3, 2023 17:17
33c8dc6
to
312e49d
Compare
Sergio0694
force-pushed
the
dev/generated-marshaller-attribute
branch
from
October 3, 2023 17:22
312e49d
to
1013cfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change 💣
A change that is either binary or source breaking
optimization 🚀
Performance improvement to existing APIs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the new
[D2DGeneratedPixelShaderDescriptor]
attribute to trigger the D2D1 source generator, and also includes a code fixer to automatically add it to shader types, along with several new diagnostic analyzers to provide useful errors.API breakdown