Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disable notify #3176

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Fix disable notify #3176

merged 2 commits into from
Oct 9, 2020

Conversation

charhate
Copy link
Contributor

@charhate charhate commented Oct 8, 2020

Updating notification from Certificates table is clearing few other fields of the certificate like description, role.
Introducing a new minimal API that would just update notification information.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 58.03% when pulling d5ce38b on charhate:ui_changes into e078d33 on Netflix:master.

@charhate charhate merged commit b59c76d into Netflix:master Oct 9, 2020
@havron havron mentioned this pull request Jun 16, 2021
Closed
@havron havron mentioned this pull request Jun 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hosseinsh hosseinsh hosseinsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charhate @coveralls @hosseinsh