Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding rotation toggle+filtering to frontend #3633

Closed
havron opened this issue Jun 16, 2021 · 4 comments
Closed

adding rotation toggle+filtering to frontend #3633

havron opened this issue Jun 16, 2021 · 4 comments

Comments

@havron
Copy link
Contributor

havron commented Jun 16, 2021

👋 In my fork, I recently added the ability to toggle and filter a Certificate's rotation field directly on the certificates list (table) view - I wanted to ask here if it would be of value to raise a PR for it? Since it does add another column to the frontend, I didn't want to clutter the certificates view if there isn't enough general interest in this. For me, it's very useful to be able to quickly see+filter which certs aren't using autorotate and which are without going into the edit view for each cert!

Here's the code: havron@3390c89

It builds on @charhate's certificate table update API in #3176 🙂

@hosseinsh
Copy link
Contributor

Hi @havron, this seems a nice addition to the Lemur UI. From experience, I notice the overhead of multiple clicks to see if a certificate has auto-rotate enabled, and this is one of the common operations.
I will seek the opinion of the other members, and report back on the general interest.

@hosseinsh
Copy link
Contributor

@havron looks like there is popular demand for this feature. looking forward to a PR, whenever you get around to it.

@havron
Copy link
Contributor Author

havron commented Jun 23, 2021

Yay, happy to hear that! Just opened a PR: #3646.

@havron
Copy link
Contributor Author

havron commented Jun 29, 2021

Closing now that it's merged

@havron havron closed this as completed Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants