Move Size to StaticArraysCore.jl
#1094
Conversation
|
This LGTM. |
| Size(::Type{Adjoint{T, A}}) where {T, A <: AbstractVecOrMat{T}} = Size(Size(A)[2], Size(A)[1]) | ||
| Size(::Type{Transpose{T, A}}) where {T, A <: AbstractVecOrMat{T}} = Size(Size(A)[2], Size(A)[1]) | ||
| Size(::Type{Symmetric{T, A}}) where {T, A <: AbstractMatrix{T}} = Size(A) | ||
| Size(::Type{Hermitian{T, A}}) where {T, A <: AbstractMatrix{T}} = Size(A) | ||
| Size(::Type{Diagonal{T, A}}) where {T, A <: AbstractVector{T}} = Size(Size(A)[1], Size(A)[1]) | ||
| Size(::Type{<:LinearAlgebra.AbstractTriangular{T, A}}) where {T,A} = Size(A) |
There was a problem hiding this comment.
Should this be moved to StaticArraysCore as well? Technically it is type piracy.
There was a problem hiding this comment.
There are some additional definitions below with types from base.
There was a problem hiding this comment.
StaticArraysCore currently doesn't import LinearAlgebra so that's why I didn't more them. Is there a use for these methods in StaticArraysCore without StaticArrays?
I know this is type piracy but it should be harmless since StaticArrays in practice "owns" Size.
There was a problem hiding this comment.
I know this is type piracy but it should be harmless since StaticArrays in practice "owns" Size.
That's why I assumed it is mostly technical. It would only become an issue if some other package wants to use these Size functionalities without depending on StaticArrays itself.
Some of the definitions below don't even use LinearAlgebra (or some other standard library), e.g., Base.prod or definitions for Tuples.
Generally, I would assume that it's fine for StaticArraysCore to depend on LinearAlgebra as it is a standard library and I think usually any package with StaticArraysCore in the dependency tree will have LinearAlgebra in the dependency tree anyway.
There was a problem hiding this comment.
Since the PR to core is already merged and tagged, let's leave that to a new PR.
There was a problem hiding this comment.
Basically all of StaticArrays is type piracy, e.g. *(::SMatrix, ::SVector) is type piracy since StaticArrays owns neither the function nor the types.
There was a problem hiding this comment.
I think this might actually not only be a theoretical problem but cause issues with generated functions: JuliaDiff/ForwardDiff.jl#599 (comment)
|
Maybe some functions like Defining them later in StaticArrays seems to cause problems for |
|
I think moving |
Counterpart to JuliaArrays/StaticArraysCore.jl#13