Update two_factor_authenticatable.rb

[anasteele206]

update_attributes is deprecated and will be removed from Rails 6.1 (please, use update instead)

[menisy]

@Houdini Can we please merge this soon?

[flanger001]

Bumping for visibility

[mitchellhenke]

Is there an opportunity to merge this in the near future? 🙂

[Houdini]

Hello, thanks for your commit.
update_attributes was used as it doesn't trigger callbacks. As far as I know update will trigger them.
Why do you think trigger them is a good idea? This change may break logic

[mitchellhenke]

Thanks for considering it!

It’s aliased to update so behavior shouldn’t change, and it’s deprecated as of 6.0: https://github.com/rails/rails/blob/v5.2.4.4/activerecord/lib/active_record/persistence.rb#L432

[Houdini]

Thanks for link. That make sense. Please let me check it more

[flanger001]

@Houdini any chance you can fast track this? This PR has been open for 8 months. @mitchellhenke gave all the information necessary and this is really a small change that won't break anything. Either that or allow other maintainers per #193?

[josef-krabath]

@Houdini can you merge this PR please?
As @mitchellhenke pointed out, update_attributes is an alias method of update.

Rails 6.0.x shows the following deprecation waringing:

DEPRECATION WARNING: update_attributes is deprecated and will be removed from Rails 6.1 (please, use update instead)

Rails 6.1 finally removed the method. As long as this PR is not merged, this gem is no longer usable in new Rails projects.

[kengreeff]

Bump