Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project dead? #193

Open
flanger001 opened this issue Jun 22, 2020 · 19 comments
Open

Is this project dead? #193

flanger001 opened this issue Jun 22, 2020 · 19 comments

Comments

@flanger001
Copy link

The last commit to master was 2019-07-25 and there are lots of open PRs that haven't been acknowledged, #188 in particular. Additionally there is no activity in the Gitter chat. Is this project dead? Are you accepting new maintainers?

@steobrien
Copy link

@Houdini a quick ping on this – thanks for your work maintaining this library so far. Before submitting a PR to fix a bug I've found, I want to make sure the project is active and accepting contributions?

@anasteele206
Copy link

I would be open to taking ownership of this repo to oversee further development.

@jherdman
Copy link

@Houdini sorry to pile on in this PR, but it'd be helpful to know the state of this library.

@flanger001
Copy link
Author

I think the best option here is going to be forking unfortunately.

@flanger001
Copy link
Author

I will be happy to fork this into a new organization and give people maintainer access on it.

@sudhindra
Copy link

@flanger001 Can you please let me know if any forked library supports rails 6.1, happy to contribute
@Houdini

@jasonperrone
Copy link

@sudhindra I opened a PR a while ago for the Rails 6 stuff. You could fork your own project and steal the PRs you need.

@jasonperrone
Copy link

Sorry, it wasn't me who did that PR. Losing track because I am finding I have to fix a lot of gems lately for either Rails 6.1 compatibility or Ruby 3 compatibility #204

@kengreeff
Copy link

@Houdini do you think we could add a few more people to this as maintainers?

@baarkerlounger
Copy link

baarkerlounger commented Feb 8, 2022

Have forked this here https://github.com/baarkerlounger/two_factor_authentication for the time being (happy to create PRs from that here or have commits cherry-picked if that helps, if this repo gets going again). Works in testing so far with Rails 7 and Turbo, and specs run again.

@strzibny
Copy link

strzibny commented Feb 9, 2022

@baarkerlounger thanks a lot!

@baarkerlounger
Copy link

Seems like no movement in this repo still. Given that, would anyone else like to help maintain a fork ☝️? What do people think about publishing to RubyGems? (Would need a new name presumably).

@strzibny
Copy link

strzibny commented Mar 16, 2022

I actually decided to fix https://github.com/wmlele/devise-otp. It now works for Rails 7 and the only thing missing is updating README and doing a proper release. So if someone needs maintained and up to date OTP solution join us :). I got commit and RubyGems push rights from the original dev, so no blockers.

@baarkerlounger
Copy link

@strzibny any major advantages to that project over this one?

@strzibny
Copy link

Not really, although I am not sure if two_factor_authentication ships with JavaScript QR code library to show the image. I like it since it's simple, small codebase, and we used it at work (I maintained Rails 5 fork before going to fix it for Rails 7).

@flanger001
Copy link
Author

Thanks @strzibny (love Deployment From Scratch btw) and @baarkerlounger for taking care of this stuff - I actually did end up forking it into a new org myself: https://github.com/devise2fa/two_factor_authentication - but I never did anything with it afterwards because I felt the whole thing of cutting a gem was going to be a pain. However, if anyone wants to get in and actually do it, I'll happily turn over the org.

@strzibny
Copy link

Thanks @flanger001!

Btw I just released devise-otp 0.3.0 which I use with Rails 7 and Hotwire.

@baarkerlounger
Copy link

@flanger001 I submitted a pull request to your repo with all the changes I made on my fork. Any interest in merging and releasing as a new gem still? (Happy to be added as a maintainer also), or are you moving on to devise-otp rather?

@flanger001
Copy link
Author

@baarkerlounger I'm very sorry! I just got this and I will respond to you there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants