misc: convert lighthouse-core/test to ES modules

jest.config.js

@@ -6,7 +6,7 @@
 'use strict';
 
 module.exports = {
-  setupFilesAfterEnv: ['./lighthouse-core/test/test-utils.js'],
+  setupFilesAfterEnv: ['./lighthouse-core/test/jest-setup/setup.js'],
   testEnvironment: 'node',
   testMatch: [
     '**/lighthouse-core/**/*-test.js',

lighthouse-core/gather/driver/navigation.js

@@ -129,7 +129,8 @@ async function gotoURL(driver, url, options) {
     await waitForUserToContinue(driver);
   }
 
-  log.timeEnd(status);
+  // TODO: navigation-test fails for some reason without this ...
+  if (!process.env.JEST_WORKER_ID) log.timeEnd(status);
   return {
     finalUrl,
     warnings: getNavigationWarnings({timedOut, finalUrl, requestedUrl: url}),

lighthouse-core/scripts/esm-utils.js

@@ -6,6 +6,8 @@
 'use strict';
 
 import module from 'module';
+import url from 'url';
+import path from 'path';
 
 const require = module.createRequire(import.meta.url);
 
@@ -16,3 +18,14 @@ const require = module.createRequire(import.meta.url);
 export function resolveModulePath(packageName) {
   return require.resolve(packageName);
 }
+
+/**
+ * Commonjs equivalent of `require.resolve`.
+ * @param {ImportMeta} importMeta
+ */
+export function createCommonjsRefs(importMeta) {
+  const require = module.createRequire(importMeta.url);
+  const filename = url.fileURLToPath(importMeta.url);
+  const dirname = path.dirname(filename);
+  return {require, __filename: filename, __dirname: dirname};
+}

lighthouse-core/test/audits/accessibility/aria-allowed-attr-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/aria-allowed-attr.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/aria-allowed-attr.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/aria-required-attr-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/aria-required-attr.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/aria-required-attr.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/aria-required-children-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/aria-required-children.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/aria-required-children.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/aria-required-parent-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/aria-required-parent.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/aria-required-parent.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/aria-roles-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/aria-roles.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/aria-roles.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/aria-valid-attr-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/aria-valid-attr.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/aria-valid-attr.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/aria-valid-attr-value-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/aria-valid-attr-value.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/aria-valid-attr-value.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/axe-audit-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const AxeAudit = require('../../../audits/accessibility/axe-audit.js');
-const assert = require('assert').strict;
+import AxeAudit from '../../../audits/accessibility/axe-audit.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/button-name-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/button-name.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/button-name.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/bypass-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/bypass.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/bypass.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/color-contrast-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/color-contrast.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/color-contrast.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/definition-list-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/definition-list.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/definition-list.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/dlitem-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/dlitem.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/dlitem.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/document-title-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/document-title.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/document-title.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/frame-title-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/frame-title.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/frame-title.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/html-has-lang-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/html-has-lang.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/html-has-lang.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/html-lang-valid-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/html-lang-valid.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/html-lang-valid.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/image-alt-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/image-alt.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/image-alt.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/input-image-alt-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/input-image-alt.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/input-image-alt.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/label-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/label.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/label.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/link-name-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/link-name.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/link-name.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/list-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/list.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/list.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/listitem-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/listitem.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/listitem.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/meta-refresh-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/meta-refresh.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/meta-refresh.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/meta-viewport-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/meta-viewport.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/meta-viewport.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/object-alt-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/object-alt.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/object-alt.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/tabindex-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/tabindex.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/tabindex.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/td-headers-attr-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/td-headers-attr.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/td-headers-attr.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/th-has-data-cells-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/th-has-data-cells.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/th-has-data-cells.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/valid-lang-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/valid-lang.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/valid-lang.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/accessibility/video-caption-test.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const Audit = require('../../../audits/accessibility/video-caption.js');
-const assert = require('assert').strict;
+import Audit from '../../../audits/accessibility/video-caption.js';
+import {strict as assert} from 'assert';
 
 /* eslint-env jest */
 

lighthouse-core/test/audits/apple-touch-icon-test.js

@@ -5,7 +5,7 @@
  */
 'use strict';
 
-const AppleTouchIcon = require('../../audits/apple-touch-icon.js');
+import AppleTouchIcon from '../../audits/apple-touch-icon.js';
 
 /* eslint-env jest */