-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: convert lighthouse-core/test to ES modules #13295
Changes from all commits
51516a7
f4b3152
c25a378
b3d35a9
aa077f9
67ead9b
2d2944d
ec26108
5f75927
0bfb34d
0ca9ad6
8abe5a1
cdd346a
83f6dbc
6ea8233
60fcb3f
75484e2
b28c493
2265777
a92c993
0a2942e
5272656
17aed3e
ba645e1
5f55fbf
0f639e2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,8 +5,8 @@ | |
*/ | ||
'use strict'; | ||
|
||
const Audit = require('../../../audits/accessibility/aria-allowed-attr.js'); | ||
const assert = require('assert').strict; | ||
import Audit from '../../../audits/accessibility/aria-allowed-attr.js'; | ||
import {strict as assert} from 'assert'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: do we want to start doing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We use this current form in other places to, so let's handle it everywhere after this PR lands. tracking #13883 |
||
|
||
/* eslint-env jest */ | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the benefit of reducing churn in this change by providing this, but it does seem like we should be looking to the future, too. e.g. new files that need a
_dirname + '/path/to/something'
, should really be doingnew URL('/path/to/something', import.meta.url)
rather than encouraging further use of__filename
and_dirname
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed-#13953