-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(viewer): accept lhr from fragment #12557
Conversation
We want to update the "View Report" link in web.dev to just link to our Viewer app, so we don't need to maintain the one web.dev is using. Should we do postMessage there, or use a fragment like this PR is proposing? |
For places that can use the postMessage, that feels much safer for LHRs. I've definitely seen a 2MB LHR before (though I guess with gzip we'll probably always be OK? LHR structure is pretty repetitive). Might be worth preventing the open in viewer message in DevTools when we know it'll be too big. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after team discussion we decided to adopt this, but if it starts causing problems we’ll remove it.
this lgtm
@googlebot I consent. |
(#12519 should land first)
This will make "open in viewer" possible in devtools.
The fragment url is cleared when the page loads. Treemap keeps it around. Seems good for Viewer b/c there is a "save as gist" button to get a short link, but treemap has no such thing.