Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(viewer): accept lhr from fragment #12557

Merged
merged 31 commits into from
Jul 23, 2021
Merged

misc(viewer): accept lhr from fragment #12557

merged 31 commits into from
Jul 23, 2021

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented May 25, 2021

(#12519 should land first)

This will make "open in viewer" possible in devtools.

The fragment url is cleared when the page loads. Treemap keeps it around. Seems good for Viewer b/c there is a "save as gist" button to get a short link, but treemap has no such thing.

@connorjclark connorjclark requested a review from a team as a code owner May 25, 2021 20:59
@connorjclark connorjclark requested review from adamraine and removed request for a team May 25, 2021 20:59
@google-cla google-cla bot added the cla: yes label May 25, 2021
Base automatically changed from treemap-encode to master May 27, 2021 21:07
@connorjclark
Copy link
Collaborator Author

We want to update the "View Report" link in web.dev to just link to our Viewer app, so we don't need to maintain the one web.dev is using. Should we do postMessage there, or use a fragment like this PR is proposing?

@patrickhulce
Copy link
Collaborator

We want to update the "View Report" link in web.dev to just link to our Viewer app, so we don't need to maintain the one web.dev is using. Should we do postMessage there, or use a fragment like this PR is proposing?

For places that can use the postMessage, that feels much safer for LHRs. I've definitely seen a 2MB LHR before (though I guess with gzip we'll probably always be OK? LHR structure is pretty repetitive). Might be worth preventing the open in viewer message in DevTools when we know it'll be too big.

@google-cla
Copy link

google-cla bot commented Jun 10, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jun 10, 2021
@google-cla
Copy link

google-cla bot commented Jun 21, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Jun 28, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after team discussion we decided to adopt this, but if it starts causing problems we’ll remove it.

this lgtm

lighthouse-core/report/html/renderer/report-ui-features.js Outdated Show resolved Hide resolved
@paulirish
Copy link
Member

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants