Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open in viewer" is broken in devtools #12841

Closed
2 tasks done
joshunger opened this issue Aug 2, 2021 · 3 comments
Closed
2 tasks done

"Open in viewer" is broken in devtools #12841

joshunger opened this issue Aug 2, 2021 · 3 comments

Comments

@joshunger
Copy link

joshunger commented Aug 2, 2021

FAQ

URL

https://www.alltrails.com/hawaii/oahu

What happened?

  1. Open devtools > Lighthouse > Run report.
  2. Click kebab menu > Open in Viewer.

What did you expect?

EXPECTED: The current report opens in the Lighthouse Viewer Application.
ACTUAL: Does not open the current report and shows the upload page.
image

What have you tried?

None.

How were you running Lighthouse?

Chrome DevTools

Lighthouse Version

8.1.0

Chrome Version

No response

Node Version

No response

Relevant log output

No response

@connorjclark
Copy link
Collaborator

connorjclark commented Aug 2, 2021

It isn't meant to be shown in DevTools right now...

#12557 enables support in DevTools, but landed after the 8.1 release. Unfortunately it is too late for Chrome 93. We have until Aug 14 to release a fix for Chrome 94. This will be a problem in stable from Aug 31 - Sep 21.

The ideal fix here is just to cut another release (which will include #12557 which I know works).

no longer works in devtools

To be clear, it never worked / was never available in DevTools before.

Thanks for bringing to our attention.


CDT has a css rule meant to disable this option: https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/panels/lighthouse/lighthousePanel.css;l=34

However, this class was changed in https://github.com/GoogleChrome/lighthouse/pull/12505/files#diff-3b6ecbfa7cbcdc8427b89d815be2b4047bf88e049d7bf6f2cfe7e5a675bb2220L396 , and the dependency in CDT stylesheets was not apparent.

@joshunger
Copy link
Author

joshunger commented Aug 2, 2021

@connorjclark got it thanks for the help and clarification! Would you like me to edit the issue text?

@connorjclark connorjclark changed the title Open in viewer no longer works in devtools "Open in viewer" is broken in devtools Aug 2, 2021
@connorjclark
Copy link
Collaborator

got it thanks for the help and clarification! Would you like me to edit the issue text?

No worries, I tweaked the title myself.

In the meantime we are adding a disclaimer to the viewer: #12846

We have a scheduled release on Aug 10, which will fix this issue, so I'll go ahead and close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants