Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: split CI into unit and smoke workflows #12422

Merged
merged 2 commits into from
Apr 29, 2021
Merged

tests: split CI into unit and smoke workflows #12422

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f16c6b7
tests: split CI into unit and smoke workflows
brendankenny Apr 28, 2021
be6bbad
tweaks
brendankenny Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
matrix:
os: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
name: unit - ${{ matrix.os == 'ubuntu-latest' && 'ubuntu' || 'windows' }}
name: unit - ${{ matrix.os == 'ubuntu-latest' && 'Ubuntu' || 'Windows' }}

steps:
- name: git clone
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/smoke.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

jobs:
# `smoke` runs as a matrix across 4 jobs:
# * The smoketest groups are split across two runners, to parallelize.
# * The smoke tests are split into two batches, to parallelize.
# * Then, those are run with both Chrome stable and ToT Chromium, in parallel
smoke:
strategy:
Expand All @@ -19,9 +19,9 @@ jobs:
runs-on: ubuntu-latest
env:
# The smokehouse tests run by job `test set 1`. `test set 2` will run the rest.
SMOKE_GROUP_1: a11y oopif pwa pwa2 pwa3 dbw redirects errors offline
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SMOKE_CLOUD_1? :P

SMOKE_BATCH_1: a11y oopif pwa pwa2 pwa3 dbw redirects errors offline
# Job named e.g. "Chrome stable, test set 1".
name: Chrome ${{ matrix.chrome-channel }}, group ${{ matrix.smoke-test-invert == false && '1' || '2' }}
name: Chrome ${{ matrix.chrome-channel }}, batch ${{ matrix.smoke-test-invert == false && '1' || '2' }}

steps:
- name: git clone
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:
- run: sudo apt-get install xvfb
- name: Run smoke tests
run: |
xvfb-run --auto-servernum yarn c8 yarn smoke --debug -j=1 --retries=2 --invert-match ${{ matrix.smoke-test-invert }} $SMOKE_GROUP_1
xvfb-run --auto-servernum yarn c8 yarn smoke --debug -j=1 --retries=2 --invert-match ${{ matrix.smoke-test-invert }} $SMOKE_BATCH_1
yarn c8 report --reporter text-lcov > smoke-coverage.lcov

- name: Upload test coverage to Codecov
Expand All @@ -66,7 +66,7 @@ jobs:
# Only run smoke tests for windows against stable chrome.
smoke-windows:
runs-on: windows-latest
name: Chrome stable, Windows
name: Windows

steps:
- name: git clone
Expand Down