Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: split CI into unit and smoke workflows #12422

Merged
merged 2 commits into from
Apr 29, 2021
Merged

tests: split CI into unit and smoke workflows #12422

merged 2 commits into from
Apr 29, 2021

Conversation

brendankenny
Copy link
Member

@brendankenny brendankenny commented Apr 28, 2021

Splits the smoke stuff out of ci.yml and into its own smoke.yml. This grew out of frustration with the remaining CI flakes and how "Cancel workflow" -> "Re-run jobs" would then cancel and re-run all of the smoke and unit jobs, when usually it's just a single job. After making the change, though, it's also just easier to read with all the smoke stuff in its own file.

Also tried to improve the CI job names. Check them out down in the checks section. Get your 🚲🏚️s in now :)

@brendankenny brendankenny requested a review from a team as a code owner April 28, 2021 20:47
@brendankenny brendankenny requested review from connorjclark and removed request for a team April 28, 2021 20:47
@google-cla google-cla bot added the cla: yes label Apr 28, 2021
@@ -0,0 +1,110 @@
name: smoke
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing changed in here but a few comments and the name values for all three jobs

@connorjclark
Copy link
Collaborator

Get your 🚲🏚️s in now :)

would love to drop 💡🏠

@brendankenny
Copy link
Member Author

Get your 🚲🏚️s in now :)

would love to drop 💡🏠

ha, I'm pretty over it too. If you can think of good naming for the workflow and jobs, happy to get a vote going on them :)

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm!

@paulirish
Copy link
Member

paulirish commented Apr 28, 2021

@brendankenny you okay owning the "required checks" juggling required for this? as long as we don't have any land-when-green active this shouldn't be too big a problem.

@brendankenny
Copy link
Member Author

you okay owning the "required checks" juggling required for this?

No problem. I'll try to get it in first thing tomorrow so hopefully it will be relatively painless for everyone.

@@ -19,9 +19,9 @@ jobs:
runs-on: ubuntu-latest
env:
# The smokehouse tests run by job `test set 1`. `test set 2` will run the rest.
SMOKE_GROUP_1: a11y oopif pwa pwa2 pwa3 dbw redirects errors offline
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SMOKE_CLOUD_1? :P

@connorjclark
Copy link
Collaborator

ha, I'm pretty over it too. If you can think of good naming for the workflow and jobs, happy to get a vote going on them :)

CI?

@brendankenny brendankenny merged commit c93834a into master Apr 29, 2021
@brendankenny brendankenny deleted the splitci branch April 29, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants