-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: split CI into unit and smoke workflows #12422
Conversation
@@ -0,0 +1,110 @@ | |||
name: smoke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing changed in here but a few comments and the name
values for all three jobs
would love to drop 💡🏠 |
ha, I'm pretty over it too. If you can think of good naming for the workflow and jobs, happy to get a vote going on them :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wfm!
@brendankenny you okay owning the "required checks" juggling required for this? as long as we don't have any land-when-green active this shouldn't be too big a problem. |
No problem. I'll try to get it in first thing tomorrow so hopefully it will be relatively painless for everyone. |
.github/workflows/smoke.yml
Outdated
@@ -19,9 +19,9 @@ jobs: | |||
runs-on: ubuntu-latest | |||
env: | |||
# The smokehouse tests run by job `test set 1`. `test set 2` will run the rest. | |||
SMOKE_GROUP_1: a11y oopif pwa pwa2 pwa3 dbw redirects errors offline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SMOKE_CLOUD_1
? :P
CI? |
Splits the smoke stuff out of
ci.yml
and into its ownsmoke.yml
. This grew out of frustration with the remaining CI flakes and how "Cancel workflow" -> "Re-run jobs" would then cancel and re-run all of the smoke and unit jobs, when usually it's just a single job. After making the change, though, it's also just easier to read with all the smoke stuff in its own file.Also tried to improve the CI job names. Check them out down in the checks section. Get your 🚲🏚️s in now :)