core(errors-in-console): properly define default options #12200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10198
#11901 did the real fix, but didn't notice that #9480 had defined the previously empty
defaultOptions
as a static method and not a getter.Classic case of unit vs integration tests:
audit-runner
does and using that for all unit tests instead of calling.audit()
directly. That would take care of context being initialized correctly and it would do theAuditProduct
->AuditResult
transformation so tests could run on the real audit output expected in the LHR.