Skip to content

Commit

Permalink
core(errors-in-console): properly define default options
Browse files Browse the repository at this point in the history
  • Loading branch information
brendankenny committed Mar 4, 2021
1 parent 18eacb9 commit 66f9e7b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lighthouse-core/audits/errors-in-console.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class ErrorLogs extends Audit {
}

/** @return {AuditOptions} */
static defaultOptions() {
static get defaultOptions() {
// Any failed network requests with error messsage aren't actionable
return {ignoredPatterns: ['ERR_BLOCKED_BY_CLIENT.Inspector']};
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/test/audits/errors-in-console-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ describe('ConsoleMessages error logs audit', () => {
'url': 'https://www.facebook.com/tr/',
'text': 'Failed to load resource: net::ERR_BLOCKED_BY_CLIENT.Inspector',
}],
}, {options: ErrorLogsAudit.defaultOptions()});
}, {options: ErrorLogsAudit.defaultOptions});
assert.equal(auditResult.score, 1);
assert.equal(auditResult.details.items.length, 0);
});
Expand Down

0 comments on commit 66f9e7b

Please sign in to comment.