Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Fix enum check in test #29517

Merged
merged 1 commit into from
Aug 1, 2024
Merged

{AKS} Fix enum check in test #29517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/azure-cli/azure/cli/command_modules/acs/base_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,9 @@ def validate_decorator_mode(decorator_mode) -> bool:
:return: bool
"""
is_valid_decorator_mode = False
try:

if isinstance(decorator_mode, DecoratorMode):
FumingZhang marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole function can be simplified as one line:

return isinstance(decorator_mode, DecoratorMode) and decorator_mode in DecoratorMode

is_valid_decorator_mode = decorator_mode in DecoratorMode
# will raise TypeError in Python >= 3.8
except TypeError:
pass

return is_valid_decorator_mode

Expand Down