{AKS} Fix enum check in test #29517
Merged
{AKS} Fix enum check in test #29517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FumingZhang
requested review from
zhoxing-ms,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
AKS |
microsoft-github-policy-service
bot
added
Auto-Assign
|
Please fix CI issues |
FumingZhang
force-pushed
the
fuming/aks-misc-0730
branch
from
3f07771 to
e5f79ee
Compare
jiasli
reviewed
Jul 30, 2024
jiasli
approved these changes
Jul 31, 2024
zhoxing-ms
approved these changes
Jul 31, 2024
bebound
approved these changes
Jul 31, 2024
yanzhudd
approved these changes
Jul 31, 2024
jiasli
reviewed
Aug 1, 2024
| @@ -26,11 +26,9 @@ def validate_decorator_mode(decorator_mode) -> bool: | |||
| :return: bool | |||
| """ | |||
| is_valid_decorator_mode = False | |||
| try: | |||
|
|
|||
| if isinstance(decorator_mode, DecoratorMode): | |||
There was a problem hiding this comment.
The whole function can be simplified as one line:
return isinstance(decorator_mode, DecoratorMode) and decorator_mode in DecoratorMode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
{AKS} Fix enum check in test
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.