Add list of personal repositories that nonowners are pushing to #96

larsxschneider · 2018-01-26T18:47:16Z

Find personal repositories that non-owners are pushing to.
These kind of repositories should be moved into organizations.
Only look at active users (not suspended!) and only look at pushes
of the last 4 weeks.

pluehne

Another good metric to keep track of. See my minor comments below 🙂.

pluehne · 2018-01-29T12:56:32Z

docs/_data/navigation.yml

@@ -43,6 +43,8 @@
      url: "/housekeeping-git-requests"
    - title: "API Requests"
      url: "/housekeeping-api-requests"
+    - title: "Personal Non-Owner Push"


Merriam-Webster considers “nonowner” a proper word.

Aside from this, could we rename this to “Personal Repositories with Nonowner Pushes”? I think the title is a bit hard to get otherwise.

Any idea for something shorter? Otherwise the menu might look weird

pluehne · 2018-01-29T12:57:25Z

docs/demo-data/repositories-personal-non-owner-push.tsv

@@ -0,0 +1,4 @@
+date	personal repositories with non-owner pushes


If we decide to rename the report as suggested above, we should change the TSV header as well 🙂.

pluehne · 2018-01-29T12:58:13Z

updater/reports/ReportReposPersonalNonOwnerPush.py

+from .ReportDaily import *
+
+# Find personal repositories that non-owners are pushing to.
+# These kind of repositories should be moved into organizations.


I’d just write “These repositories should be moved …”

pluehne · 2018-01-29T12:59:02Z

updater/reports/ReportReposPersonalNonOwnerPush.py

+			WHERE
+				    users.type = "user"
+				AND users.suspended_at IS NULL
+				AND pushes.created_at > DATE_SUB(NOW(), INTERVAL 4 WEEK)


As I suggested in my comment on #95, I’d not use NOW() etc.

pluehne · 2018-01-29T12:59:26Z

updater/reports/ReportReposPersonalNonOwnerPush.py

+				JOIN users ON repositories.owner_id = users.id
+				JOIN pushes ON pushes.repository_id = repositories.id
+			WHERE
+				    users.type = "user"


Again, the spacing looks odd to me 🙂.

aligned to the lines below. not ok?

pluehne

Thanks for the adjustments 👍. I have some more minor remarks below.

pluehne · 2018-01-29T14:56:44Z

docs/_data/navigation.yml

@@ -43,6 +43,8 @@
      url: "/housekeeping-git-requests"
    - title: "API Requests"
      url: "/housekeeping-api-requests"
+    - title: "Repository Location"
+      url: "/housekeeping-repo-personal-non-owner-push"


We could shorten the URL as well 🙂.

pluehne · 2018-01-29T14:57:28Z

updater/reports/ReportReposPersonalNonOwnerPush.py

+# of the last 4 weeks.
+class ReportReposPersonalNonOwnerPush(ReportDaily):
+	def name(self):
+		return "repositories-personal-non-owner-push"


Let’s drop the - in non-owner for consistency.

pluehne · 2018-01-29T14:59:49Z

updater/reports/ReportReposPersonalNonOwnerPush.py

+# These repositories should be moved into organizations.
+# Only look at active users (not suspended!) and only look at pushes
+# of the last 4 weeks.
+class ReportReposPersonalNonOwnerPush(ReportDaily):


Would it make sense to make pushes plural? It’s just a bit odd for me to talk about push in singular (also concerns the output filename repositories-personal-non-owner-push below and the demo data TSV file).

pluehne · 2018-01-29T15:03:21Z

docs/housekeeping-repo-personal-non-owner-push.html

+		<p>
+			Repositories in user accounts should only be pushed to by their owners as these repositories might become unavailable or deleted if the owner leaves the company.
+		</p>
+		<p> Repositories, in which people actively collaborate, should be <a href="https://help.github.com/articles/about-repository-transfers/">transferred</a> to an organization account.


Why’s the formatting of this <p> different from the first one?

pluehne · 2018-01-29T15:10:01Z

docs/housekeeping-repo-location.html

+---
+layout: default
+title: Forks
+permalink: /housekeeping-repo-personal-non-owner-push


The permalink looks still off?

pluehne · 2018-01-29T15:10:36Z

docs/housekeeping-repo-location.html

+<div class="chart-placeholder">
+	<h3>Personal Repositories with Nonowner Pushes in the Last 4 Weeks</h3>
+	<canvas
+		data-url="{{ site.dataURL }}/repositories-personal-non-owner-push.tsv"


Looks like you forgot to update the URL 🙂.

pluehne · 2018-01-29T15:12:32Z

docs/housekeeping-repo-location.html

+			Repositories in user accounts should only be pushed to by their owners as these repositories might become unavailable or deleted if the owner leaves the company.
+		</p>
+		<p>
+			Repositories, in which people actively collaborate, should be <a href="https://help.github.com/articles/about-repository-transfers/">transferred</a> to an organization account.


The commas in “Repositories, in which people actively collaborate, should …” should not be set, because the “in which” clause is a dependent one (or a concretization of the subject “repositories”).

pluehne · 2018-01-29T15:13:23Z

docs/housekeeping-repo-location.html

+	></canvas>
+	<div class="info-box">
+		<p>
+			Repositories in user accounts should only be pushed to by their owners as these repositories might become unavailable or deleted if the owner leaves the company.


I’d put a comma before “… by their owners[,] as these repositories …”

pluehne · 2018-01-29T15:14:32Z

updater/reports/ReportReposPersonalNonOwnerPushes.py

@@ -0,0 +1,38 @@
+from .ReportDaily import *
+
+# Find personal repositories that non-owners are pushing to.


Might rewrite “non-owners” here as well 🙂.

Find personal repositories that non-owners are pushing to. These repositories should be moved into organizations. Only look at active users (not suspended!) and only look at pushes of the last 4 weeks.

pluehne

Many thanks for the addressing the suggestions! Everything looks good to me now 😄.

pluehne reviewed Jan 29, 2018

View reviewed changes

pluehne assigned larsxschneider and pluehne Jan 29, 2018

pluehne added the enhancement label Jan 29, 2018

larsxschneider force-pushed the lars/personal-non-owner branch from 53003ad to 7e8a0e9 Compare January 29, 2018 14:55

pluehne reviewed Jan 29, 2018

View reviewed changes

larsxschneider force-pushed the lars/personal-non-owner branch from 7e8a0e9 to 6f4a2cd Compare January 29, 2018 15:02

pluehne reviewed Jan 29, 2018

View reviewed changes

larsxschneider force-pushed the lars/personal-non-owner branch from 6f4a2cd to 9f7b4b6 Compare January 29, 2018 15:09

pluehne reviewed Jan 29, 2018

View reviewed changes

larsxschneider force-pushed the lars/personal-non-owner branch from 9f7b4b6 to f0dade4 Compare January 29, 2018 15:13

pluehne reviewed Jan 29, 2018

View reviewed changes

larsxschneider force-pushed the lars/personal-non-owner branch from f0dade4 to 7373e6f Compare January 29, 2018 15:16

add list of personal repositories that non-owners are pushing to

9715dab

Find personal repositories that non-owners are pushing to. These repositories should be moved into organizations. Only look at active users (not suspended!) and only look at pushes of the last 4 weeks.

larsxschneider force-pushed the lars/personal-non-owner branch from 7373e6f to 9715dab Compare January 29, 2018 15:17

pluehne approved these changes Jan 29, 2018

View reviewed changes

pluehne merged commit 9d843e7 into master Jan 29, 2018

pluehne deleted the lars/personal-non-owner branch January 29, 2018 15:23

pluehne changed the title ~~add list of personal repositories that non-owners are pushing to~~ Add list of personal repositories that nonowners are pushing to Jan 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add list of personal repositories that nonowners are pushing to #96

Add list of personal repositories that nonowners are pushing to #96

larsxschneider commented Jan 26, 2018

pluehne left a comment

pluehne Jan 29, 2018

larsxschneider Jan 29, 2018

pluehne Jan 29, 2018

pluehne Jan 29, 2018

pluehne Jan 29, 2018

pluehne Jan 29, 2018

larsxschneider Jan 29, 2018

pluehne left a comment

pluehne Jan 29, 2018

pluehne Jan 29, 2018

pluehne Jan 29, 2018

pluehne Jan 29, 2018

pluehne Jan 29, 2018

pluehne Jan 29, 2018

pluehne Jan 29, 2018

pluehne Jan 29, 2018

pluehne Jan 29, 2018

pluehne left a comment

		@@ -0,0 +1,4 @@
		date personal repositories with non-owner pushes

		@@ -0,0 +1,38 @@
		from .ReportDaily import *

		# Find personal repositories that non-owners are pushing to.

Add list of personal repositories that nonowners are pushing to #96

Add list of personal repositories that nonowners are pushing to #96

Conversation

larsxschneider commented Jan 26, 2018

pluehne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pluehne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pluehne left a comment

Choose a reason for hiding this comment