-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list of abandoned organizations #95
Conversation
6e44db6
to
7c2d22d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good addition to the housekeeping reports. I listed some suggestions below 🙂.
></canvas> | ||
<div class="info-box"> | ||
<p> | ||
An organizations is considered <em>abandoned</em> if none of its |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d suggest not wrapping these lines manually and leaving this to the editor program. My argument is that diffs tend to become very ugly when flow text is manually rewrapped later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true. but diffs for very long lines are ugly too. I dunno
repositories). | ||
</p> | ||
<p> | ||
If the content has still value, then you could <a href="https://help.github.com/articles/archiving-repositories/">archive</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d write “still has value” instead of “has still value.”
query = ''' | ||
SELECT | ||
users.login AS "organization", | ||
date(MAX(pushes.created_at)) AS "last push" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t DATE
be in uppercase for consistency?
JOIN users ON repositories.owner_id = users.id | ||
JOIN pushes ON pushes.repository_id = repositories.id | ||
WHERE | ||
users.type = "organization" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation looks off by 3 spaces to me.
GROUP BY | ||
users.id | ||
HAVING | ||
MAX(pushes.created_at) < DATE_SUB(NOW(), INTERVAL 1 YEAR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d prefer using the Python-based approach to selecting time ranges instead of using DATE_SUB(NOW())
and INTERVAL 1 YEAR
.
The main reason for this is that I think it would be better to exclude today’s data from the report and to start with yesterday instead.
Find the organizations that have not received a push for the longest time. Only look at organizations that have not received a push for at least one year. Only look at repositories that are still maintained (not archived!).
7c2d22d
to
a63950b
Compare
@pluehne please review, again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me 😄!
Find the organizations that have not received a push for the longest time.
Only look at organizations that have not received a push for at least one
year.