Support precompile #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eigmax
reviewed
Jan 9, 2025
| use std::time::Instant; | ||
| use zkm_sdk::{prover::ClientCfg, prover::ProverInput, ProverClient}; | ||
|
|
||
| pub const DEFAULT_PROVER_NETWORK_RPC: &str = "https://152.32.186.45:20002"; |
eigmax
reviewed
Jan 9, 2025
| let prover_client = ProverClient::new(&client_config).await; | ||
| log::info!("new prover client,ok."); | ||
|
|
||
| let mut prover_input = ProverInput { |
There was a problem hiding this comment.
Can we plz create a new or init function in ProverInput so we don't have to pass empty variables?
Learn how to use Default::default()
eigmax
reviewed
Jan 9, 2025
| @@ -143,14 +153,25 @@ impl Prover for NetworkProver { | |||
| //log::info!("generate_proof step: {}", get_status_response.step); | |||
| match get_status_response.step { | |||
| 0 => log::info!("generate_proof : queuing the task."), | |||
| 1 => log::info!("generate_proof : splitting the task."), | |||
| 2 => log::info!("generate_proof : proving the task."), | |||
| 1 => { | |||
There was a problem hiding this comment.
Don't hardcode, what's does 0, 1, 2 mean?
eigmax
reviewed
Jan 9, 2025
| let cert_path = env::var("CERT_PATH").unwrap_or("".to_string()); | ||
| let key_path = env::var("KEY_PATH").unwrap_or("".to_string()); | ||
| let domain_name = env::var("DOMAIN_NAME").unwrap_or(DEFALUT_PROVER_NETWORK_DOMAIN.to_string()); | ||
| let private_key = env::var("PRIVATE_KEY").unwrap_or("".to_string()); |
There was a problem hiding this comment.
Rename the PRIVATE KEY to PROOF_NETWORK_PRVKEY, make the variable name precise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.