Removed use of tempArray
#114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-use of tempArray to to generate arrays was causing issues with react and change detection that uses simple object equality `===`. Because the array was re-used in some cases react would fail to detect changes in style object
|
This fixes a bug when upgrading to React 16. Any chance of getting this merged? |
misino
approved these changes
Oct 24, 2017
|
Please merge this! |
|
@mpowaga Hi, would it be possible to merge this fix? Because it is critical for supporting React 16. |
|
The same issue has been solved in #121 but thanks for sending this PR @lukashlavacka! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating my project to [email protected] I experienced strange issue where position of handles would be wrong on initial load. After debugging I determined the issue is caused by re-use of
tempArrayto generate some arrays. As far as I know react uses simple object equality===when detecting changes of props and state. Because the array was re-used in some cases react would fail to detect changes in style object.Fixes #115